Fix labeler labelling everything as backend#2041
Merged
samfreund merged 1 commit intoPhotonVision:mainfrom Aug 6, 2025
Merged
Conversation
Member
Author
|
Tested and verified locally on my fork: Gold856#7 (modified labeler won't apply on this PR) |
samfreund
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the labeler is provided with multiple match objects, the default behavior is to apply the label if any of them match. This causes all PRs to be incorrectly labeled as "backend", since they will usually match the glob of not modifying photon-server's index.html. This changes the logic so that all match objects must be true, which means the criteria for the "backend" label to be applied now requires a PR to either have modified photon-core or photon-server, and for photon-server's index.html file to not be modified.
Meta
Merge checklist: