Skip to content

Fix labeler labelling everything as backend#2041

Merged
samfreund merged 1 commit intoPhotonVision:mainfrom
Gold856:fix-labeler
Aug 6, 2025
Merged

Fix labeler labelling everything as backend#2041
samfreund merged 1 commit intoPhotonVision:mainfrom
Gold856:fix-labeler

Conversation

@Gold856
Copy link
Member

@Gold856 Gold856 commented Aug 6, 2025

Description

When the labeler is provided with multiple match objects, the default behavior is to apply the label if any of them match. This causes all PRs to be incorrectly labeled as "backend", since they will usually match the glob of not modifying photon-server's index.html. This changes the logic so that all match objects must be true, which means the criteria for the "backend" label to be applied now requires a PR to either have modified photon-core or photon-server, and for photon-server's index.html file to not be modified.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner August 6, 2025 20:27
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Aug 6, 2025
@Gold856
Copy link
Member Author

Gold856 commented Aug 6, 2025

Tested and verified locally on my fork: Gold856#7 (modified labeler won't apply on this PR)

@Gold856 Gold856 removed the backend Things relating to photon-core and photon-server label Aug 6, 2025
@samfreund samfreund merged commit 2c98d10 into PhotonVision:main Aug 6, 2025
69 of 70 checks passed
@Gold856 Gold856 deleted the fix-labeler branch August 7, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants