Fix buildAndCopyUI and update build instructions#2036
Merged
samfreund merged 1 commit intoPhotonVision:mainfrom Aug 5, 2025
Merged
Fix buildAndCopyUI and update build instructions#2036samfreund merged 1 commit intoPhotonVision:mainfrom
samfreund merged 1 commit intoPhotonVision:mainfrom
Conversation
samfreund
requested changes
Aug 5, 2025
samfreund
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Gradle plugin we use for invoking Node and npm seems to not support the same tasks for pnpm. Define our own task for building the UI. Add install instructions for pnpm because you need it installed globally for the task to work. (minor fix to code block because it was easy to fix while updating the instructions.)
Meta
Merge checklist: