Skip to content

Fix buildAndCopyUI and update build instructions#2036

Merged
samfreund merged 1 commit intoPhotonVision:mainfrom
Gold856:fix-pnpm
Aug 5, 2025
Merged

Fix buildAndCopyUI and update build instructions#2036
samfreund merged 1 commit intoPhotonVision:mainfrom
Gold856:fix-pnpm

Conversation

@Gold856
Copy link
Member

@Gold856 Gold856 commented Aug 5, 2025

Description

The Gradle plugin we use for invoking Node and npm seems to not support the same tasks for pnpm. Define our own task for building the UI. Add install instructions for pnpm because you need it installed globally for the task to work. (minor fix to code block because it was easy to fix while updating the instructions.)

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner August 5, 2025 05:35
@github-actions github-actions bot added documentation Anything relating to https://docs.photonvision.org backend Things relating to photon-core and photon-server labels Aug 5, 2025
Copy link
Member

@samfreund samfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need pnpm only or pnpm@exe? I have both installed right now, so I'm not quite sure how to check.

Only pnpm is needed, the only difference is that pnpm@exe is self-contained, they have the same functionality.

@samfreund samfreund merged commit 923f956 into PhotonVision:main Aug 5, 2025
43 checks passed
@Gold856 Gold856 deleted the fix-pnpm branch August 7, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server documentation Anything relating to https://docs.photonvision.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants