Skip to content

Run metrics with debug false to reduce log spam#2027

Merged
samfreund merged 1 commit intoPhotonVision:mainfrom
samfreund:despam-metrics-logs
Aug 8, 2025
Merged

Run metrics with debug false to reduce log spam#2027
samfreund merged 1 commit intoPhotonVision:mainfrom
samfreund:despam-metrics-logs

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Aug 4, 2025

Description

Because our metrics are updating every five seconds, our previous approach of logging all the commands we run for metrics results in a lot of debug log spam. This adjusts the shellExec for metrics so that we no longer spam.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner August 4, 2025 01:25
@samfreund samfreund force-pushed the despam-metrics-logs branch from c6a05ea to 6ccc572 Compare August 4, 2025 01:30
@samfreund samfreund requested review from Gold856 and mcm001 August 4, 2025 01:37
@samfreund samfreund force-pushed the despam-metrics-logs branch from 6ccc572 to ae3f20e Compare August 4, 2025 04:07
@samfreund samfreund added backend Things relating to photon-core and photon-server bug Something isn't working labels Aug 4, 2025
@samfreund samfreund force-pushed the despam-metrics-logs branch from ae3f20e to 671249b Compare August 8, 2025 04:50
@Gold856 Gold856 removed the bug Something isn't working label Aug 8, 2025
@Gold856 Gold856 enabled auto-merge (squash) August 8, 2025 05:47
@Gold856 Gold856 disabled auto-merge August 8, 2025 05:49
Copy link
Member

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleaned up the debug output nicely:
image
No more metrics command spam.

@samfreund samfreund merged commit 0ea108e into PhotonVision:main Aug 8, 2025
43 checks passed
@samfreund samfreund deleted the despam-metrics-logs branch August 8, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants