Fix 'Resource leak: <variable> is never closed' warnings#2023
Merged
Gold856 merged 2 commits intoPhotonVision:mainfrom Aug 19, 2025
Merged
Fix 'Resource leak: <variable> is never closed' warnings#2023Gold856 merged 2 commits intoPhotonVision:mainfrom
Gold856 merged 2 commits intoPhotonVision:mainfrom
Conversation
kcooney
force-pushed
the
fix-auto-closeable-resource-leaks
branch
2 times, most recently
from
123b881 to
68cf4e9
Compare
samfreund
added
bug
kcooney
force-pushed
the
fix-auto-closeable-resource-leaks
branch
from
68cf4e9 to
ac732d6
Compare
Gold856
requested changes
Aug 8, 2025
photon-lib/src/main/java/org/photonvision/simulation/VideoSimUtil.java
Outdated
Show resolved
Hide resolved
Changes: - Upgrade JUnit from 5.10.0 to 5.11.4 (so @autoclose can be used) - Use Files.copy() to copy files - Use try-with-resources when calling Files.list() or Files.walk() - Use try-with-resources or @autoclose to close PhotonCamera and PhotonCameraSim objects created by tests - Use try-with-resources when calling AprilTag.generate36h11AprilTagImage() - Update SQLConfigTest to use @tempdir
kcooney
force-pushed
the
fix-auto-closeable-resource-leaks
branch
from
ac732d6 to
2a40b18
Compare
Contributor
Author
|
FYI: rebased the branch off of main |
Gold856
previously approved these changes
Aug 19, 2025
auto-merge was automatically disabled
August 19, 2025 01:36
Head branch was pushed to by a user without write access
kcooney
force-pushed
the
fix-auto-closeable-resource-leaks
branch
from
49c4e12 to
7d622c2
Compare
Gold856
approved these changes
Aug 19, 2025
7 tasks
Gold856
added a commit
that referenced
this pull request
Oct 10, 2025
## Description #2023 changed how file uploads were handled to use `Files.copy`, but incorrectly didn't specify the `REPLACE_EXISTING` copy option, causing file uploads to fail if the file already existed. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
## Description PhotonVision#2023 changed how file uploads were handled to use `Files.copy`, but incorrectly didn't specify the `REPLACE_EXISTING` copy option, causing file uploads to fail if the file already existed. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix numerous places where using AutoCloseable objects without closing them.
Changes:
@AutoClosecan be used)Files.copy()to copy filesFiles.list()orFiles.walk()@AutoCloseto closePhotonCameraandPhotonCameraSimobjects created by testsSQLConfigTestto use@TempDirMeta
Merge checklist: