Add PNP_DISTANCE_TRIG_SOLVE strategy to C++#2021
Merged
mcm001 merged 8 commits intoPhotonVision:mainfrom Aug 10, 2025
Merged
Conversation
Based off of the implementation of the PNP_DISTANCE_TRIG_SOLVE strategy for Java
Gold856
requested changes
Aug 7, 2025
7b3d3e7 to
b27f785
Compare
Gold856
requested changes
Aug 8, 2025
photon-lib/src/main/native/include/photon/PhotonPoseEstimator.h
Outdated
Show resolved
Hide resolved
79c48c5 to
350ba68
Compare
Gold856
approved these changes
Aug 8, 2025
mcm001
approved these changes
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port of the Java
PNP_DISTANCE_TRIG_SOLVEstrategy to C++. Includes both the actual strategy, and the unit test for it.This is mostly identical to the Java version, with some differences listed below:
Updatewas called, butAddHeadingDatawas never calledUpdatein a loop for every unread result like the other C++ tests forPhotonPoseEstimatorMeta
Merge checklist: