Skip to content

Dark mode and minor interface tweaks#2016

Merged
samfreund merged 18 commits intoPhotonVision:mainfrom
DevonRD:theme-shenanigans
Aug 4, 2025
Merged

Dark mode and minor interface tweaks#2016
samfreund merged 18 commits intoPhotonVision:mainfrom
DevonRD:theme-shenanigans

Conversation

@DevonRD
Copy link
Contributor

@DevonRD DevonRD commented Jul 29, 2025

Does the following:

  • Adds dark mode
    Overhauls the vuetify theme structure to allow for a seamless transition between light and dark themes. Also paves the way for an easy implementation of user-created custom themes in the future - when I get some more free time! This still has some minor cleanup on the way, but only for behind-the-scenes structure.
    Note: the light mode is not completely identical to the existing default theme. For the purpose of organization and consistency, I ended up changing some button colors/banner colors/etc to hopefully make things more intuitive. For example, button colors were sort of all over the place, so I tried to stick to red for deleting, yellow for more "active" actions (e.g. finish calibration, restart, change settings), and blue for more "passive" actions (e.g. open/close a popup, display a stream, show details). Open to suggestions about this. These minor changes will probably go unnoticed if you don't compare side by side.
image image image image
  • Replaces banners with alerts for better style control, a necessary change for theming

  • Fixes calibration settings filtering for unrelated board type (switch to v-if instead of v-show, which wasn't working properly). Some input on this would be nice to make sure the existing filters are right for chessboard vs charuco.

  • Adds a nicer-looking documentation page when running in dev mode because the old one made me want to vomit. Enjoy

image
  • Fixes wrong delete message when deleting a camera from either camera matching or camera settings page
  • Slightly increases button icon sizes for increased visibility
  • Fixes spacing in camera matching view "more cameras here" card

@samfreund
Copy link
Member

Lint pls 😃

Also, feel free to ping me over any OD questions and go ham on the UI. I'll lyk my thoughts.

@DevonRD
Copy link
Contributor Author

DevonRD commented Jul 29, 2025

Lint pls 😃

Also, feel free to ping me over any OD questions and go ham on the UI. I'll lyk my thoughts.

yeah just draft so far, gonna lint/etc after i polish up the rest. expect a dm about getting an object detection example running soon :)

samfreund

This comment was marked as resolved.

@samfreund samfreund dismissed their stale review August 3, 2025 22:25

resolved

@DevonRD DevonRD marked this pull request as ready for review August 4, 2025 00:16
@DevonRD DevonRD requested a review from a team as a code owner August 4, 2025 00:16
@samfreund
Copy link
Member

I won't be at my bench for a hot minute, @Gold856 if u can finalize testing we can ship this or I can do a final test later tonight.

Copy link
Member

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of lines have been compacted for no apparent reason, but honestly, I like it better that way, so I'm fine with leaving it. Also like the reordering of things like the pipeline actions and the items for each camera card in Camera Matching. I think it makes more sense that way.

@samfreund samfreund requested a review from Gold856 August 4, 2025 02:06
@samfreund samfreund enabled auto-merge (squash) August 4, 2025 03:55
@samfreund samfreund disabled auto-merge August 4, 2025 03:55
@samfreund samfreund enabled auto-merge (squash) August 4, 2025 03:56
@samfreund samfreund added the frontend Having to do with PhotonClient and its related items label Aug 4, 2025
@samfreund samfreund merged commit fce54d1 into PhotonVision:main Aug 4, 2025
42 checks passed
@Gold856 Gold856 mentioned this pull request Aug 4, 2025
6 tasks
@DevonRD DevonRD deleted the theme-shenanigans branch August 5, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants