Add an overload of resetHeadingData() which takes in a Rotation3d#2013
Merged
samfreund merged 1 commit intoPhotonVision:mainfrom Jul 28, 2025
Merged
Conversation
samfreund
approved these changes
Jul 27, 2025
auto-merge was automatically disabled
July 27, 2025 21:20
Head branch was pushed to by a user without write access
ac69ffa to
203e87d
Compare
Gold856
previously requested changes
Jul 27, 2025
Member
Gold856
left a comment
There was a problem hiding this comment.
Needs a C++ and Python version
Contributor
Author
@Gold856 there are no equivalent APIs in Python or C++. Heading data is only used for |
A very good point about feature parity needing to be extant before we can require it.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In PR #1933
PhotonPoseEstimator.resetHeadingData(double, Rotation2d)was added togive users the option to manually clear the heading buffer and add an initial
heading, specified as a
Rotation2d. This works for teams that passRotation2ddatato
addHeadingData(), but teams that prefer to useRotation3dfor headings needto provide an initial heading as a
Rotation2din order to clear the heading buffer.This change adds an overload of
resetHeadingData()that takes in aRotation3d,mirroring the overloads for
addHeadingData().Meta
Merge checklist: