Update logic for metric publisher topic name#2011
Merged
samfreund merged 6 commits intoPhotonVision:mainfrom Jul 24, 2025
Merged
Update logic for metric publisher topic name#2011samfreund merged 6 commits intoPhotonVision:mainfrom
samfreund merged 6 commits intoPhotonVision:mainfrom
Conversation
mcm001
requested changes
Jul 23, 2025
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
mcm001
approved these changes
Jul 24, 2025
Contributor
mcm001
left a comment
There was a problem hiding this comment.
I don't see a good way to test or shim this logic so no tests needed here imo. Hope you tested this manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getName()gives the full string, not just the title of the topic. Therefore, it needs to be split in order to get the title of the topic.Let this be a lesson to test things when something has changed before they are merged.
Meta
Merge checklist: