Skip to content

Update logic for metric publisher topic name#2011

Merged
samfreund merged 6 commits intoPhotonVision:mainfrom
samfreund:metrics-publisher-hostname-fix
Jul 24, 2025
Merged

Update logic for metric publisher topic name#2011
samfreund merged 6 commits intoPhotonVision:mainfrom
samfreund:metrics-publisher-hostname-fix

Conversation

@samfreund
Copy link
Member

getName() gives the full string, not just the title of the topic. Therefore, it needs to be split in order to get the title of the topic.

Let this be a lesson to test things when something has changed before they are merged.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner July 23, 2025 03:18
@samfreund samfreund requested review from Gold856 and mcm001 July 24, 2025 00:37
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a good way to test or shim this logic so no tests needed here imo. Hope you tested this manually.

@samfreund samfreund merged commit 4b5bc6a into PhotonVision:main Jul 24, 2025
42 checks passed
@samfreund samfreund deleted the metrics-publisher-hostname-fix branch July 24, 2025 04:23
@Gold856 Gold856 added the backend Things relating to photon-core and photon-server label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants