Skip to content

Update metrics publisher hostname when hostname is changed#2008

Merged
samfreund merged 3 commits intoPhotonVision:mainfrom
samfreund:metrics-publisher-hostname-fix
Jul 22, 2025
Merged

Update metrics publisher hostname when hostname is changed#2008
samfreund merged 3 commits intoPhotonVision:mainfrom
samfreund:metrics-publisher-hostname-fix

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Jul 22, 2025

Description

When the hostname changes, the key of the metrics publisher will not be immediately updated. To fix this, we will check the key against the hostname and re-initialize the publisher if they do not match.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • Figure out a way to only extract models for the relevant hardware (ideally only pack the necessary models, but idk how viable that is since it necessitates a different JAR per)

@samfreund samfreund requested a review from a team as a code owner July 22, 2025 02:22
@samfreund samfreund force-pushed the metrics-publisher-hostname-fix branch 2 times, most recently from bda5bf3 to 1667c61 Compare July 22, 2025 02:44
mcm001
mcm001 previously approved these changes Jul 22, 2025
@samfreund samfreund force-pushed the metrics-publisher-hostname-fix branch from 5ed0d91 to 7cbdd77 Compare July 22, 2025 23:30
@samfreund samfreund enabled auto-merge (squash) July 22, 2025 23:36
@samfreund samfreund merged commit 758fbb9 into PhotonVision:main Jul 22, 2025
42 checks passed
@Gold856 Gold856 added the backend Things relating to photon-core and photon-server label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants