Update metrics publisher hostname when hostname is changed#2008
Merged
samfreund merged 3 commits intoPhotonVision:mainfrom Jul 22, 2025
Merged
Update metrics publisher hostname when hostname is changed#2008samfreund merged 3 commits intoPhotonVision:mainfrom
samfreund merged 3 commits intoPhotonVision:mainfrom
Conversation
bda5bf3 to
1667c61
Compare
mcm001
requested changes
Jul 22, 2025
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Show resolved
Hide resolved
mcm001
previously approved these changes
Jul 22, 2025
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Show resolved
Hide resolved
5ed0d91 to
7cbdd77
Compare
mcm001
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the hostname changes, the key of the metrics publisher will not be immediately updated. To fix this, we will check the key against the hostname and re-initialize the publisher if they do not match.
Meta
Merge checklist: