Add Gradle wrapper validation#2004
Merged
Gold856 merged 2 commits intoPhotonVision:mainfrom Jul 19, 2025
Merged
Conversation
samfreund
force-pushed
the
wrapper-validation
branch
from
b06de05 to
0183754
Compare
Gold856
requested changes
Jul 19, 2025
samfreund
force-pushed
the
wrapper-validation
branch
from
2b7a080 to
fb784ff
Compare
Gold856
requested changes
Jul 19, 2025
Member
Gold856
left a comment
Gold856
left a comment
There was a problem hiding this comment.
needs needs to be applied to each job, not in steps. See https://github.com/PhotonVision/photonvision/blob/main/.github/workflows/photon-api-docs.yml#L66
samfreund
force-pushed
the
wrapper-validation
branch
from
2505730 to
d71d1cb
Compare
Gold856
requested changes
Jul 19, 2025
Member
Gold856
left a comment
Gold856
left a comment
There was a problem hiding this comment.
Missing validation requirement in build-package.
Member
Author
That requires |
Gold856
approved these changes
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check gradle wrapper to avoid supply chain attacks