Dynamically import dependencies that are not critical to viewing the UI#2001
Merged
mcm001 merged 3 commits intoPhotonVision:mainfrom Jul 13, 2025
Merged
Dynamically import dependencies that are not critical to viewing the UI#2001mcm001 merged 3 commits intoPhotonVision:mainfrom
mcm001 merged 3 commits intoPhotonVision:mainfrom
Conversation
mcm001
approved these changes
Jul 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The UI currently loads ~1.73 MB of JS and 727 kB of CSS. A large portion of that is very rarely used; in particular, jsPDF and three.js are very infrequently used by users, and make up almost half of the JS bundle size. We can make the page load just a little snappier by dynamically importing those dependencies when needed, reducing the amount of JS sent over the wire and the amount of JS parsed by the browser. This does increase the total size of all the assets to 1.96 MB, while reducing the size of the main bundle to 672 kB, which seems like a good tradeoff to reduce the page load time.
The story is similar with CSS. Dyamically importing @mdi/font means the primary bundle is 403 kB, with the font CSS being 324 kB. This allows the main UI to load first, while the font can be loaded separately, which makes the page load faster overall.
Meta
Merge checklist: