Skip to content

Fix camera calibration card contents completely vanishing during calibration#1998

Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom
Gold856:fix-calibration-card-disappearing
Jul 14, 2025
Merged

Fix camera calibration card contents completely vanishing during calibration#1998
mcm001 merged 1 commit intoPhotonVision:mainfrom
Gold856:fix-calibration-card-disappearing

Conversation

@Gold856
Copy link
Member

@Gold856 Gold856 commented Jul 13, 2025

Description

Per #1972 (comment), camera calibration got broken because I accidently hid the entire contents of the camera calibration card in #1972. Now, v-show is only applied to the calibration table so that only the calibration table is hidden during calibration.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner July 13, 2025 05:01
@Gold856 Gold856 added frontend Having to do with PhotonClient and its related items styling Issue pertaining to styling issues in the PhotonClient labels Jul 13, 2025
@pwbriggs
Copy link

Thanks for the quick patch @Gold856!

@mcm001 mcm001 merged commit 8215caf into PhotonVision:main Jul 14, 2025
39 checks passed
@Gold856 Gold856 deleted the fix-calibration-card-disappearing branch July 14, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items styling Issue pertaining to styling issues in the PhotonClient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants