Skip to content

Set a more sane timeout for WS connections and log WS errors #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcm001 merged 1 commit into from
Jul 9, 2025
Merged

Set a more sane timeout for WS connections and log WS errors #1992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions photon-server/src/main/java/org/photonvision/server/DataSocketHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ private DataSocketHandler() {

public void onConnect(WsConnectContext context) {
users.add(context);
context.session.setIdleTimeout(
Duration.ofMillis(Long.MAX_VALUE)); // TODO: determine better value
context.session.setIdleTimeout(Duration.ofMillis(5000));
var remote = (InetSocketAddress) context.session.getRemoteAddress();
var host = remote.getAddress().toString() + ":" + remote.getPort();
logger.info("New websocket connection from " + host);
Expand Down
1 change: 1 addition & 0 deletions photon-server/src/main/java/org/photonvision/server/Server.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ private static void start(int port) {
ws -> {
ws.onConnect(dsHandler::onConnect);
ws.onClose(dsHandler::onClose);
ws.onError(e -> logger.error(e.toString(), e.error()));
ws.onBinaryMessage(dsHandler::onBinaryMessage);
});

Expand Down
Loading