Fix model selection on index 0#1955
Conversation
|
Could you give me some more information about the bug happening here? I don't seem to be able to reproduce it. |
When selecting the first model in the dropdown list, the UI fails to update the selected value because index 0 is implicitly converted to false in the conditional check, preventing the update logic from executing. I noticed that PR #1954 also addresses this issue, so I'm fine with whichever pr you'd choose to merge. 😄 |
Got it, I think I see what's up now. I was testing on 2025.3.1 which is why I didn't notice. We've been going through a big dependencies upgrade (including Vue 3), which is probably where that's coming from. Nice job picking up on this, but we'll probably do it thru #1954. Part of the reason it didn't get caught earlier is because that logic is likely going to be changing soon, so it wasn't the highest priority for testing. Thanks for the quick fix tho, those are important! |
Description
Fixed model selection bug where selecting the first item in the dropdown failed to update settings, as index 0 was implicitly converted to false in the condition check.
Meta
Merge checklist: