Add leading zero to log file date/time#1925
Merged
mcm001 merged 3 commits intoPhotonVision:mainfrom Apr 22, 2025
Merged
Conversation
Contributor
Author
|
Merge conflicts fixed :) |
Contributor
|
I'm not seeing any changes with the new commits. |
Contributor
Author
|
I only rebased onto upstream/main, which changed the SHAs |
samfreund
pushed a commit
to samfreund/photonvision
that referenced
this pull request
Jun 28, 2025
## Description WAS: Logs did not have a leading zero, meaning that alphabetical and temporal sort were not the same IS: Logs now have leading zeros added. This means that alphabetical sort works properly. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added --------- Co-authored-by: Craig Schardt <crschardt@fastem.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WAS: Logs did not have a leading zero, meaning that alphabetical and temporal sort were not the same
IS: Logs now have leading zeros added. This means that alphabetical sort works properly.
Meta
Merge checklist: