Fix calibration array length#1879
Merged
mcm001 merged 4 commits intoPhotonVision:mainfrom Apr 13, 2025
Merged
Conversation
19d556d to
95fffdc
Compare
I thought it was good to go earlier, but given it's a draft and failing tests now, I'm dismissing.
95fffdc to
637209e
Compare
c69478e to
da9f364
Compare
mcm001
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where rotated camera distortion coefficient arrays and rotated camera intrensic arrays were 8x bigger than they were supposed to be. The root cause was because of how the data from JsonMatOfDouble was being handled. A Mat was pulled out, then modified, then a new JsonMatOfDouble was made from the Mat. This required a conversion from a Mat to a Java array. The array was incorrectly sized as
elements * bytes, when it should've just beenelements. Due to some uncertainty as to the types of Mats passed into JsonMatOfDouble.fromMat, the expected Mat type has been explicitly documented. The added regression test rotates the calibration data 4 times, equivalent to not rotating at all. This should mean the arrays are equal, and that is what we check.Additionally fixes a bug when rotating 180 degrees that flipped width and height
Meta
Merge checklist: