Skip to content

Add an error when the connection for the end calibration request fails#1840

Merged
mcm001 merged 2 commits intoPhotonVision:mainfrom
Gold856:add-third-cal-error
Aug 8, 2025
Merged

Add an error when the connection for the end calibration request fails#1840
mcm001 merged 2 commits intoPhotonVision:mainfrom
Gold856:add-third-cal-error

Conversation

@Gold856
Copy link
Member

@Gold856 Gold856 commented Mar 22, 2025

Description

When the HTTP request to end calibration fails with a network error, the UI will show that the calibration failed, despite the fact the calibration may have actually succeeded on the server. This is most evident when you take hundreds of calibration images, and you need to wait a few minutes for the request to process. If the connection drops out for any reason (unstable connection due to use of the 2.4 GHz radio mode, or otherwise) users will now see a third error screen telling them they need to refresh the page to check the calibration manually.

This also changes the backend to broadcast out the calibration state when starting a calibration, which allows the state to be resynced if this error shows up.

Screenshot 2025-03-22 112254

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR addresses a bug, a regression test for it is added

@Gold856
Copy link
Member Author

Gold856 commented Mar 22, 2025

Draft because if the connection comes back up, you click the OK button and start another calibration without refreshing, the snapshot number doesn't reset. Unsure of the best way to fix this (could do it client side or have the server send something).

@Gold856 Gold856 force-pushed the add-third-cal-error branch from 0c6a1fe to 977ef70 Compare July 12, 2025 04:55
@Gold856 Gold856 force-pushed the add-third-cal-error branch from 977ef70 to 1a8ca29 Compare August 5, 2025 05:50
@github-actions github-actions bot added frontend Having to do with PhotonClient and its related items backend Things relating to photon-core and photon-server labels Aug 5, 2025
@Gold856 Gold856 marked this pull request as ready for review August 5, 2025 05:56
@Gold856 Gold856 requested a review from a team as a code owner August 5, 2025 05:56
@Gold856
Copy link
Member Author

Gold856 commented Aug 8, 2025

Changed the backend to always rebroadcast the calibration state when the start calibration button is clicked.

@mcm001 mcm001 merged commit 22490b8 into PhotonVision:main Aug 8, 2025
43 checks passed
@Gold856 Gold856 deleted the add-third-cal-error branch August 8, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants