Add an error when the connection for the end calibration request fails#1840
Merged
mcm001 merged 2 commits intoPhotonVision:mainfrom Aug 8, 2025
Merged
Add an error when the connection for the end calibration request fails#1840mcm001 merged 2 commits intoPhotonVision:mainfrom
mcm001 merged 2 commits intoPhotonVision:mainfrom
Conversation
Member
Author
|
Draft because if the connection comes back up, you click the |
0c6a1fe to
977ef70
Compare
977ef70 to
1a8ca29
Compare
Member
Author
|
Changed the backend to always rebroadcast the calibration state when the start calibration button is clicked. |
mcm001
approved these changes
Aug 8, 2025
photon-core/src/main/java/org/photonvision/vision/processes/VisionModule.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the HTTP request to end calibration fails with a network error, the UI will show that the calibration failed, despite the fact the calibration may have actually succeeded on the server. This is most evident when you take hundreds of calibration images, and you need to wait a few minutes for the request to process. If the connection drops out for any reason (unstable connection due to use of the 2.4 GHz radio mode, or otherwise) users will now see a third error screen telling them they need to refresh the page to check the calibration manually.
This also changes the backend to broadcast out the calibration state when starting a calibration, which allows the state to be resynced if this error shows up.
Meta
Merge checklist: