Skip to content

Add OV9281 AE startup quirk #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gold856 merged 5 commits into from
Jan 26, 2026
Merged

Add OV9281 AE startup quirk #1814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d60771d
Add OV9281 AE startup quirk
mcm001 Mar 16, 2025
6f57d11
Update docs comment
mcm001 Mar 16, 2025
a0cf05b
oop
mcm001 Mar 16, 2025
599516f
Merge branch 'main' into ov9281-fix-exposure-stuck
Gold856 Jan 23, 2026
a989a9e
Reorder and add long sleeps
Gold856 Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...re/src/main/java/org/photonvision/vision/camera/USBCameras/GenericUSBCameraSettables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,27 @@ public void setAutoWhiteBalance(boolean autoWB) {
}
}

@Override
public void setAutoExposure(boolean cameraAutoExposure) {
if (configuration.cameraQuirks.hasQuirk(CameraQuirk.ArduOV9281Controls)
&& !cameraAutoExposure) {
// OV9281 on Linux seems to sometimes ignore our exposure requests on first boot if we're in
// manual mode. Poking the camera into and out of auto exposure seems to fix it.
try {
setAutoExposureImpl(false);
Thread.sleep(2000);
setAutoExposureImpl(true);
Thread.sleep(2000);
setAutoExposureImpl(false);
} catch (InterruptedException e) {
logger.error("Thread interrupted while setting OV9281 exposure!", e);
}
} else {
setAutoExposureImpl(cameraAutoExposure);
}
}

public void setAutoExposureImpl(boolean cameraAutoExposure) {
logger.debug("Setting auto exposure to " + cameraAutoExposure);

if (!cameraAutoExposure) {
Expand Down
2 changes: 1 addition & 1 deletion photon-core/src/main/java/org/photonvision/vision/processes/VisionModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,13 +465,13 @@ boolean setPipeline(int index) {
pipelineSettings.cameraExposureRaw = 10; // reasonable default
}

settables.setExposureRaw(pipelineSettings.cameraExposureRaw);
try {
settables.setAutoExposure(pipelineSettings.cameraAutoExposure);
} catch (VideoException e) {
logger.error("Unable to set camera auto exposure!");
logger.error(e.toString());
}
settables.setExposureRaw(pipelineSettings.cameraExposureRaw);
if (cameraQuirks.hasQuirk(CameraQuirk.Gain)) {
// If the gain is disabled for some reason, re-enable it
if (pipelineSettings.cameraGain == -1) pipelineSettings.cameraGain = 75;
Expand Down
Loading