Skip to content

Check MSVC Runtime before loading natives#1809

Merged
mcm001 merged 5 commits intoPhotonVision:mainfrom
person4268:patch-1
Mar 12, 2025
Merged

Check MSVC Runtime before loading natives#1809
mcm001 merged 5 commits intoPhotonVision:mainfrom
person4268:patch-1

Conversation

@person4268
Copy link
Copy Markdown
Contributor

@person4268 person4268 commented Mar 11, 2025

Description

Checks the MSVC runtime early in startup to throw a MsvcRuntimeException instead of a generic, unclear EXCEPTION_ACCESS_VIOLATION from the JDK.

(honestly made the PR just so CI can give me a jar to test, made this in the web editor. will remove draft status once i see it build and I test it)

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR addresses a bug, a regression test for it is added

@person4268 person4268 marked this pull request as ready for review March 12, 2025 00:49
@person4268 person4268 requested a review from a team as a code owner March 12, 2025 00:49
@mcm001 mcm001 merged commit 8fe53f3 into PhotonVision:main Mar 12, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants