Merged
Conversation
General UI Refinements (PhotonVision#1678)
Fix Working on the Wrong Branch
…on into add-custom-models
…on into add-custom-models
…on into add-custom-models
…on into add-custom-models
…on into add-custom-models
forgot to clean that up
Member
Author
|
|
samfreund
force-pushed
the
yolo-duplication-fix
branch
from
16baa0c to
b692ffa
Compare
…ision into yolo-duplication-fix
…ision into yolo-duplication-fix
Member
Author
|
tested on Chris's opi and it works |
gerth2
approved these changes
Jan 13, 2025
mcm001
added a commit
to mcm001/photonvision
that referenced
this pull request
Feb 18, 2025
Somebody wanted a description, so here I am. This PR fixes an error which caused the discoverModels function to be rerun after each upload of a new model, but without clearing the list of available models. This causes any models that were on the list prior to the import to be duplicated. This PR also makes it so that uploading a model automatically updates the list of available models. --------- Co-authored-by: Matt Morley <matthew.morley.ca@gmail.com> Co-authored-by: Chris Gerth <gerth2@users.noreply.github.com>
Gold856
added
frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somebody wanted a description, so here I am.
This PR fixes an error which caused the discoverModels function to be rerun after each upload of a new model, but without clearing the list of available models. This causes any models that were on the list prior to the import to be duplicated. This PR also makes it so that uploading a model automatically updates the list of available models.