Skip to content

Make Vision pose estimation examples use all vision measurements#1706

Merged
samfreund merged 10 commits intoPhotonVision:mainfrom
spacey-sooty:fix-estimation-example
Apr 15, 2025
Merged

Make Vision pose estimation examples use all vision measurements#1706
samfreund merged 10 commits intoPhotonVision:mainfrom
spacey-sooty:fix-estimation-example

Conversation

@spacey-sooty
Copy link
Member

Resolves #1634

@spacey-sooty
Copy link
Member Author

Waiting on design decision before doing C++ and Python

@mcm001
Copy link
Contributor

mcm001 commented Jan 15, 2025

Ship it

@spacey-sooty spacey-sooty force-pushed the fix-estimation-example branch from 2226037 to 179e315 Compare January 15, 2025 03:33
@samfreund samfreund added the documentation Anything relating to https://docs.photonvision.org label Apr 14, 2025
@spacey-sooty spacey-sooty force-pushed the fix-estimation-example branch from 4aea314 to 9188f27 Compare April 14, 2025 22:15
@spacey-sooty spacey-sooty marked this pull request as ready for review April 14, 2025 22:17
@spacey-sooty spacey-sooty requested a review from a team as a code owner April 14, 2025 22:17
@spacey-sooty spacey-sooty requested a review from mcm001 April 14, 2025 22:19
@spacey-sooty spacey-sooty force-pushed the fix-estimation-example branch from fb61129 to 89438a9 Compare April 15, 2025 01:07
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty spacey-sooty force-pushed the fix-estimation-example branch from 89438a9 to 2c0d8ca Compare April 15, 2025 01:08
@mcm001
Copy link
Contributor

mcm001 commented Apr 15, 2025

Failing CI

@samfreund samfreund requested a review from mcm001 April 15, 2025 03:10
@samfreund samfreund enabled auto-merge (squash) April 15, 2025 03:22
@samfreund samfreund merged commit 1c42755 into PhotonVision:main Apr 15, 2025
39 checks passed
samfreund pushed a commit that referenced this pull request Apr 15, 2025
## Description

Updates the PhotonPoseEstimator programming documentation page to
reflect the new PhotonPoseEstimator. and add a more comprehensive
step-by-step tutorial using code from the PV Pose Estimation examples.

Updates various code examples to ensure they are matching the latest
documentation or example code on GitHub.

This PR is a successor of, and therefore closes #1765.

This PR is blocked by #1706, as the linked PR updates examples.
Closes #1757 and closes #1800 and closes #1632 and closes #1773 and
closes #1465.

## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [x] If this PR changes behavior or adds a feature, user documentation
is updated
- [x] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [x] If this PR touches configuration, this is backwards compatible
with settings back to v2024.3.1
- [x] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [x] If this PR addresses a bug, a regression test for it is added

---------

Co-authored-by: Kevin Reas <[email protected]>
Co-authored-by: Matt Morley <[email protected]>
samfreund added a commit to samfreund/photonvision that referenced this pull request Jun 28, 2025
samfreund pushed a commit to samfreund/photonvision that referenced this pull request Jun 28, 2025
## Description

Updates the PhotonPoseEstimator programming documentation page to
reflect the new PhotonPoseEstimator. and add a more comprehensive
step-by-step tutorial using code from the PV Pose Estimation examples.

Updates various code examples to ensure they are matching the latest
documentation or example code on GitHub.

This PR is a successor of, and therefore closes PhotonVision#1765.

This PR is blocked by PhotonVision#1706, as the linked PR updates examples.
Closes PhotonVision#1757 and closes PhotonVision#1800 and closes PhotonVision#1632 and closes PhotonVision#1773 and
closes PhotonVision#1465.

## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [x] If this PR changes behavior or adds a feature, user documentation
is updated
- [x] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [x] If this PR touches configuration, this is backwards compatible
with settings back to v2024.3.1
- [x] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [x] If this PR addresses a bug, a regression test for it is added

---------

Co-authored-by: Kevin Reas <[email protected]>
Co-authored-by: Matt Morley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Anything relating to https://docs.photonvision.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect pose estimation vision correction java example

3 participants