Camera disconnected + stream normalization improvements#1701
Merged
mcm001 merged 12 commits intoPhotonVision:mainfrom Jan 14, 2025
Merged
Camera disconnected + stream normalization improvements#1701mcm001 merged 12 commits intoPhotonVision:mainfrom
mcm001 merged 12 commits intoPhotonVision:mainfrom
Conversation
crschardt
reviewed
Jan 12, 2025
Contributor
|
If I try to "start calibration", I don't see the processed stream (it almost seems to freeze). But if I manually navigate to http://10.17.36.12:1181/stream.mjpg and http://10.17.36.12:1182/stream.mjpg , I do. And if I reload the webpage, I see it too. |
Contributor
Author
Odd, I can't seem to reproduce this, is it device/camera specific? Quickly tested on vite dev run with arducam 9281 |
Contributor
|
I also cannot reproduce on my opi. |
mcm001
approved these changes
Jan 14, 2025
mcm001
pushed a commit
to mcm001/photonvision
that referenced
this pull request
Feb 18, 2025
Gold856
added
frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Images are before and after comparison.
Does the following:
Fixes logic for disconnected cameras in camera matching view to properly indicate the actual status of the camera. Previously disconnected cameras were falsely flagged as mismatches.
Sorts camera modules by (active, connected) / mismatch -> (active, disconnected) -> deactivated -> unassigned
Massively (as far as I can tell) improves camera stream height normalization logic in camera matching view, and guts all the unnecessary logic previously used to accomplish this
(verification that it works, for me at least)
New stream spinner to make camera stream size normalization work nicely - needed matching or transparent background
P.S. camera lost image, don't think I didn't see you...