Added constructor overload to PhotonCameraSim for AprilTagFieldLayout#1692
Merged
mcm001 merged 4 commits intoPhotonVision:mainfrom Jan 8, 2025
Merged
Added constructor overload to PhotonCameraSim for AprilTagFieldLayout#1692mcm001 merged 4 commits intoPhotonVision:mainfrom
mcm001 merged 4 commits intoPhotonVision:mainfrom
Conversation
mcm001
approved these changes
Jan 8, 2025
Contributor
mcm001
left a comment
mcm001
left a comment
There was a problem hiding this comment.
Seems reasonable, assuming this does what ya need it to now
spacey-sooty
reviewed
Jan 8, 2025
photon-lib/src/main/java/org/photonvision/simulation/PhotonCameraSim.java
Outdated
Show resolved
Hide resolved
Member
Do we want Python and C++ to have this as well? |
Contributor
|
We should probably keep api parity, yeah |
Member
|
@JochemvdBroek are you happy to do Python and C++ or would you like help with it? |
Contributor
Author
|
@spacey-sooty, I am not familiar enough with c++ to make these changes, so it would be a big help if you could look at it. Could you then also change the tagLayout back to final? |
Member
Not an issue, thanks for opening a PR and detailed issue :) |
mcm001
reviewed
Jan 8, 2025
photon-lib/src/main/native/include/photon/simulation/PhotonCameraSim.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1691