Skip to content

Add custom models#1687

Merged
mcm001 merged 46 commits intoPhotonVision:mainfrom
samfreund:add-custom-models
Jan 8, 2025
Merged

Add custom models#1687
mcm001 merged 46 commits intoPhotonVision:mainfrom
samfreund:add-custom-models

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Jan 7, 2025

This allows for uploading of custom object detection models via the GUI.
image
image

Note #1685 ought to be merged prior to this one, as it contains the same edits.

@samfreund samfreund requested review from a team as code owners January 7, 2025 20:16
@samfreund
Copy link
Member Author

Someone should test that the files upload properly on a PI, I haven't tested it on that platform as I don't have one readily available.

@mcm001
Copy link
Contributor

mcm001 commented Jan 7, 2025

Do you think this would make sense as its own card on the settings page instead of piled in with all the other buttons?

@samfreund
Copy link
Member Author

Do you think this would make sense as its own card on the settings page instead of piled in with all the other buttons?

I think that would also work. My reasoning was that these were files that would go on the device, so I put it in there. I can make it a separate card tho, that's not much work.

@samfreund
Copy link
Member Author

fixes #1354

@samfreund
Copy link
Member Author

@mcm001 this should be good to go

@gerth2
Copy link
Contributor

gerth2 commented Jan 8, 2025

image

Quick test on pi3, looks like the upload card is visible and "works" in the context it accepts files.

image

The front-end camera interface uses this logic to disallow selecting object detection when there's no backend for it available, is it possible to use the same mechanism on the settings page to hide the upload card on platforms where it can't be run?

@samfreund
Copy link
Member Author

This check failed because of dependencies it looks like. Do we think it could be related to #1690?

@spacey-sooty
Copy link
Member

This check failed because of dependencies it looks like. Do we think it could be related to #1690?

Nah CI is just a bit silly sometimes

Copy link
Contributor

@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheeeeee

@mcm001 mcm001 merged commit 27684ee into PhotonVision:main Jan 8, 2025
mcm001 pushed a commit to mcm001/photonvision that referenced this pull request Feb 18, 2025
@Gold856 Gold856 added documentation Anything relating to https://docs.photonvision.org frontend Having to do with PhotonClient and its related items backend Things relating to photon-core and photon-server labels Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server documentation Anything relating to https://docs.photonvision.org frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants