Change from k2024Crescendo to kDefaultField for AprilTagFieldLayout#1667
Merged
spacey-sooty merged 2 commits intoPhotonVision:mainfrom Jan 3, 2025
Merged
Change from k2024Crescendo to kDefaultField for AprilTagFieldLayout#1667spacey-sooty merged 2 commits intoPhotonVision:mainfrom
spacey-sooty merged 2 commits intoPhotonVision:mainfrom
Conversation
de96f73 to
6035ff1
Compare
Member
Author
|
Blocked on wpilibsuite/allwpilib#7618 |
This reduces the things we need to update each year Signed-off-by: Jade Turner <[email protected]>
6035ff1 to
7d32ccf
Compare
mcm001
approved these changes
Jan 2, 2025
Contributor
mcm001
left a comment
There was a problem hiding this comment.
You gotta ingest the allwpilib update but otherwise ja lgtm
Member
Author
I think since the patch is in dev artifacts and this is for examples we have to wait till its in a release |
mcm001
added a commit
to mcm001/photonvision
that referenced
this pull request
Feb 18, 2025
…hotonVision#1667) This reduces the things we need to update each year Signed-off-by: Jade Turner <[email protected]> Co-authored-by: Matt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the things we need to update each year