Skip to content

Fix release action glob exclusion#1644

Merged
crschardt merged 1 commit intoPhotonVision:mainfrom
crschardt:fix-release-action-failure
Dec 20, 2024
Merged

Fix release action glob exclusion#1644
crschardt merged 1 commit intoPhotonVision:mainfrom
crschardt:fix-release-action-failure

Conversation

@crschardt
Copy link
Contributor

In softprops/action-gh-release, when using an glob pattern to exclude files, all of the files to exclude must be specified on one line. Splitting them to multiple lines causes all files to match one of the two lines.

To combine on one line, use | between the patterns.

@crschardt crschardt requested a review from a team as a code owner December 20, 2024 22:50
@mcm001 mcm001 changed the title Fix release action failure in 2025 beta-7 Fix release action glob exclusion Dec 20, 2024
@crschardt crschardt merged commit e506ac6 into PhotonVision:main Dec 20, 2024
@crschardt crschardt deleted the fix-release-action-failure branch December 20, 2024 23:11
mcm001 pushed a commit to mcm001/photonvision that referenced this pull request Feb 18, 2025
In softprops/action-gh-release, when using an glob pattern to exclude files, all of the files to exclude must be specified on one line. Splitting them to multiple lines causes all files to match one of the two lines. 

To combine on one line, use `|` between the patterns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants