Skip to content

Guarantee cameras always have the same ports#123

Merged
mcm001 merged 4 commits intoPhotonVision:masterfrom
mcm001:stream-port-persistance
Sep 16, 2020
Merged

Guarantee cameras always have the same ports#123
mcm001 merged 4 commits intoPhotonVision:masterfrom
mcm001:stream-port-persistance

Conversation

@mcm001
Copy link
Contributor

@mcm001 mcm001 commented Sep 15, 2020

Also reimplements a bunch of cscore stuff because of a weird bug

@mcm001 mcm001 requested a review from a team as a code owner September 15, 2020 17:35
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #123 into master will increase coverage by 0.72%.
The diff coverage is 82.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
+ Coverage     51.68%   52.41%   +0.72%     
- Complexity      642      654      +12     
============================================
  Files           156      155       -1     
  Lines          5212     5243      +31     
  Branches        487      481       -6     
============================================
+ Hits           2694     2748      +54     
+ Misses         2334     2306      -28     
- Partials        184      189       +5     
Impacted Files Coverage Δ Complexity Δ
...onvision/vision/processes/VisionModuleManager.java 75.00% <77.77%> (+1.31%) 6.00 <1.00> (+1.00)
...ision/vision/frame/consumer/MJPGFrameConsumer.java 70.96% <81.81%> (+18.58%) 14.00 <11.00> (+10.00)
...rg/photonvision/vision/processes/VisionModule.java 44.27% <90.00%> (+2.16%) 19.00 <1.00> (+1.00)
...sion/common/configuration/CameraConfiguration.java 67.24% <100.00%> (+0.57%) 7.00 <0.00> (ø)
.../photonvision/common/hardware/GPIO/CustomGPIO.java 40.00% <0.00%> (-10.00%) 8.00% <0.00%> (-1.00%)
...ava/org/photonvision/common/hardware/Platform.java 50.00% <0.00%> (-2.09%) 7.00% <0.00%> (-1.00%)
...otonvision/common/configuration/NetworkConfig.java 45.16% <0.00%> (-1.90%) 2.00% <0.00%> (+1.00%) ⬇️
...otonvision/common/configuration/ConfigManager.java 39.13% <0.00%> (-0.56%) 21.00% <0.00%> (ø%)
...n/dataflow/networktables/NetworkTablesManager.java 29.72% <0.00%> (-0.28%) 3.00% <0.00%> (ø%)
...in/java/org/photonvision/server/SocketHandler.java 10.48% <0.00%> (-0.26%) 3.00% <0.00%> (ø%)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73c698...58d5d6c. Read the comment docs.

Bankst
Bankst previously approved these changes Sep 15, 2020
@mcm001 mcm001 force-pushed the stream-port-persistance branch from 6ac3a55 to 58d5d6c Compare September 15, 2020 19:30
@mcm001 mcm001 merged commit 2413255 into PhotonVision:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants