Skip to content

Add limelight 4 support#52

Merged
spacey-sooty merged 11 commits intomainfrom
limelight-4
Sep 15, 2025
Merged

Add limelight 4 support#52
spacey-sooty merged 11 commits intomainfrom
limelight-4

Conversation

@spacey-sooty
Copy link
Member

No description provided.

Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty
Copy link
Member Author

Untested

@mcm001
Copy link
Contributor

mcm001 commented Mar 10, 2025

How is this different from the other limelight images exactly?

@Juniormunk
Copy link
Contributor

I believe the config.txt needs to change so that dtoverlay=ov9281,cam0

@spacey-sooty
Copy link
Member Author

How is this different from the other limelight images exactly?

It's the same as the 3g image cause I just needed something to test builds off and the hardware is very similar

@spacey-sooty spacey-sooty changed the title Add limelight-4 supportg Add limelight 4 support Mar 12, 2025
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty
Copy link
Member Author

This works when I modify a stable image but fresh images dont work due to libcamera abi break, working on fixing libcamera will then test this as a fresh image

@spacey-sooty
Copy link
Member Author

Works with PhotonVision/photonvision#1769

@spacey-sooty spacey-sooty marked this pull request as ready for review September 12, 2025 15:02
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Copy link
Member

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, ship it!

Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty spacey-sooty merged commit 1b37b1d into main Sep 15, 2025
14 checks passed
@spacey-sooty spacey-sooty deleted the limelight-4 branch September 15, 2025 05:25
mcm001 pushed a commit to PhotonVision/photonvision that referenced this pull request Oct 21, 2025
## Description

Adds support for building images for the Luma P1. This bumps the image
modifier pin to v2025.0.4. This pulls in:

* Allow users to install any release via install.sh by @crschardt in
PhotonVision/photon-image-modifier#49
* Exit install script if run on systemcore by @crschardt in
PhotonVision/photon-image-modifier#58
* Fix --list-versions in install.sh by @crschardt in
PhotonVision/photon-image-modifier#59
* Remove large folders of firmware that (probably) isn't needed by
@crschardt in
PhotonVision/photon-image-modifier#41
* Cancel in progress runs by @spacey-sooty in
PhotonVision/photon-image-modifier#65
* Add limelight 4 support by @spacey-sooty in
PhotonVision/photon-image-modifier#52

**Full Changelog**:
PhotonVision/photon-image-modifier@v2025.0.3...v2025.0.4


## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2025.3.2
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
## Description

Adds support for building images for the Luma P1. This bumps the image
modifier pin to v2025.0.4. This pulls in:

* Allow users to install any release via install.sh by @crschardt in
PhotonVision/photon-image-modifier#49
* Exit install script if run on systemcore by @crschardt in
PhotonVision/photon-image-modifier#58
* Fix --list-versions in install.sh by @crschardt in
PhotonVision/photon-image-modifier#59
* Remove large folders of firmware that (probably) isn't needed by
@crschardt in
PhotonVision/photon-image-modifier#41
* Cancel in progress runs by @spacey-sooty in
PhotonVision/photon-image-modifier#65
* Add limelight 4 support by @spacey-sooty in
PhotonVision/photon-image-modifier#52

**Full Changelog**:
PhotonVision/photon-image-modifier@v2025.0.3...v2025.0.4


## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2025.3.2
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants