Skip to content

Upgrade to Polkadot 0.9.29#947

Merged
jasl merged 5 commits intomasterfrom
polkadot-v0.9.29
Sep 13, 2022
Merged

Upgrade to Polkadot 0.9.29#947
jasl merged 5 commits intomasterfrom
polkadot-v0.9.29

Conversation

@jasl
Copy link
Copy Markdown
Contributor

@jasl jasl commented Sep 9, 2022

paritytech/substrate@polkadot-v0.9.28...polkadot-v0.9.29

This PR changes:

@jasl jasl marked this pull request as draft September 9, 2022 09:16
@jasl jasl requested a review from kvinwang September 12, 2022 19:49
TrieDB::new(&self.db, &self.root)
.map_err(|_| anyhow::Error::msg(Error::StorageRootMismatch))
fn trie(&self) -> TrieDB<H> {
TrieDBBuilder::new(&self.db, &self.root).build()
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pub enum Error {
// InvalidStorageProof,
StorageRootMismatch,
// StorageRootMismatch,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used for build TrieDB failed, but now it always success https://github.com/paritytech/trie/blob/master/trie-db/src/triedb.rs#L81

impl Convert<Weight, Balance> for PinkRuntime {
fn convert(w: Weight) -> Balance {
w as _
w.ref_time() as _
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasl jasl marked this pull request as ready for review September 12, 2022 19:56
@jasl
Copy link
Copy Markdown
Contributor Author

jasl commented Sep 12, 2022

Upgrade rustc may broken some test samples, need update them

Copy link
Copy Markdown
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl merged commit 13f32eb into master Sep 13, 2022
@jasl jasl deleted the polkadot-v0.9.29 branch September 13, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants