Conversation
kvinwang
force-pushed
the
release-polkadot-v1.1.0
branch
from
c253492 to
de6a04f
Compare
kvinwang
force-pushed
the
release-polkadot-v1.1.0
branch
from
de6a04f to
a15217f
Compare
jasl
force-pushed
the
release-polkadot-v1.1.0
branch
from
039c7c7 to
15ee1f7
Compare
kvinwang
reviewed
Oct 10, 2023
| telemetry.as_ref().map(|(_, telemetry)| telemetry.handle()), | ||
| executor, | ||
| )?; | ||
| let client = Arc::new(client); |
Collaborator
There was a problem hiding this comment.
So, does the upstream switched to spaces from tabs for indentation?
Contributor
Author
There was a problem hiding this comment.
It should use tabs, our editor config is also configured using tabs.
However, currently, most of our codes are using space, so I still format to use spaces here.
It's better to make a separate PR for reformat to use tabs
kvinwang
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
frame_supportmacro related exports paritytech/substrate#14745StateBackend::TransactiontoPrefixedMemoryDBparitytech/substrate#14612Fixes:
Notable changes:
try-runtimesubcommand and direct users to standalone cli paritytech/substrate#14731In addition: