Conversation
jasl
force-pushed
the
polkadot-v0.9.34
branch
5 times, most recently
from
b5ef4c8 to
af6f9d2
Compare
h4x3rotab
reviewed
Jan 12, 2023
| }, | ||
| instruction_weights: InstructionWeights { | ||
| version: "3 ps", | ||
| version: "4 ps", |
Collaborator
There was a problem hiding this comment.
It's OK since we haven't published the first version.
| type AddressGenerator = Pink; | ||
| type MaxCodeLen = MaxCodeLen; | ||
| type MaxStorageKeyLen = MaxStorageKeyLen; | ||
| type UnsafeUnstableInterface = ConstBool<false>; |
Collaborator
There was a problem hiding this comment.
LGTM. We never want contracts to call unstable interfaces.
kvinwang
approved these changes
Jan 12, 2023
| type AddressGenerator = Pink; | ||
| type MaxCodeLen = MaxCodeLen; | ||
| type MaxStorageKeyLen = MaxStorageKeyLen; | ||
| type UnsafeUnstableInterface = ConstBool<false>; |
Collaborator
There was a problem hiding this comment.
LGTM. We never want contracts to call unstable interfaces.
| }, | ||
| instruction_weights: InstructionWeights { | ||
| version: "3 ps", | ||
| version: "4 ps", |
Collaborator
There was a problem hiding this comment.
It's OK since we haven't published the first version.
Contributor
Author
|
I shall merge this after SPv2 things finished |
jasl
force-pushed
the
polkadot-v0.9.34
branch
from
af6f9d2 to
d9d9925
Compare
Contributor
Author
|
I'll merge this so I can start working on Khala |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paritytech/substrate@polkadot-v0.9.33...polkadot-v0.9.34
Polkadot v0.9.34 has version bumps (and migrations this not relates to Phala), so we upgrade to this version first
Notatble changes:
sp-core 7.0.0andsp-runtime 7.0.0paritytech/substrate#12599sp-keyringandpallet-contracts-primitives7.0.0paritytech/substrate#12716sp-sandboxandwasmi-validationby newest wasmi paritytech/substrate#12501Another notice that it seems Substrate change its releasing stretegy that latest (for example)
sp-coreis 10.0 now, so we have to loosen requirements for Substrate dependencies of our crates that publish to crates.io