feature: TLS passthrough will select known app_id from TXT record w multiple entries#9
Open
wwwehr wants to merge 1 commit intoPhala-Network:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As a phala cloud operator, I want to have two dstack-ingress instances share a
given
_dstack-app-address.xxxso that I can properly route a shared hostnameusing a load balancer. Currently, the router only accepts first dns record it
discovers which, also, isn't deterministic.
Fix
Extract
select_app_addressto iterate all values in the TXT record and returnthe first whose
app_idis known to the local gateway'sappsmap. Falls backto the first parseable entry when none are locally known (preserves behavior
for single-instance setups).
The compat path (
_tapp-addresslegacy) is unchanged.Tests
test_resolve_app_address— original live DNS integration test with mock statetest_select_app_address_prefers_local— multi-record, picks local app_idtest_select_app_address_fallback_when_none_local— multi-record, fallback to first