Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Use System.Net.ServerSentEvents for parsing SSE response#32

Merged
PederHP merged 1 commit intoPederHP:mainfrom
stephentoub:sseparser
Mar 7, 2025
Merged

Use System.Net.ServerSentEvents for parsing SSE response#32
PederHP merged 1 commit intoPederHP:mainfrom
stephentoub:sseparser

Conversation

@stephentoub
Copy link
Copy Markdown
Collaborator

Pull Request

Description of Changes

System.Net.ServerSentEvents provides a robust SSE parser that is more feature complete and more efficient than using a StreamReader.

Breaking Changes

None

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@PederHP PederHP requested review from PederHP and twenzel March 7, 2025 15:50
Copy link
Copy Markdown
Owner

@PederHP PederHP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I wasn't aware the SseParser existed when I wrote this. I'll make sure the SSE server protocol support I'm finalizing also uses System.Net.ServerSentEvents.

@stephentoub
Copy link
Copy Markdown
Collaborator Author

Thank you! I wasn't aware the SseParser existed when I wrote this. I'll make sure the SSE server protocol support I'm finalizing also uses System.Net.ServerSentEvents.

Note that the 9.0 version of the package only includes SseParser. The 10.0 preview version of the package also includes SseFormatter, which is the writing side of the equation.

cc: @eiriktsarpalis

@PederHP PederHP merged commit f15b94c into PederHP:main Mar 7, 2025
1 of 2 checks passed
@stephentoub stephentoub deleted the sseparser branch March 7, 2025 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants