change types to declaration file #1258
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change packages/docusaurus-plugin-openapi-docs/src/types.ts to a declaration file.
Motivation and Context
Following on from #1220 we are still not able to run typescript checking across our site due to issues with how the internal types are defined in this package.
I have copied the docusaurus tsconfig from here into our repo https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-tsconfig/tsconfig.json
Currently if I attempt to typecheck the repo we are still seeing errors from this package
skipLibCheck will only skip .d.ts files. If I change my local node module to .d.ts these errors go away.
How Has This Been Tested?
This repo will still build successfully with these changes
Types of changes
Checklist