Enhance Coverage for EventRegistrantsModal#4865
Merged
palisadoes merged 15 commits intoPalisadoesFoundation:developfrom Nov 28, 2025
Merged
Enhance Coverage for EventRegistrantsModal#4865palisadoes merged 15 commits intoPalisadoesFoundation:developfrom
palisadoes merged 15 commits intoPalisadoesFoundation:developfrom
Conversation
…awa-admin into test/TestCoverage-EventRegistrantsModal
|
No significant changes currently retry |
Contributor
WalkthroughStylistic normalization of Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (1)
23-44: Add explicittype="button"on AddOnSpotAttendee mock buttonsThe inline mock is fine and keeps the AddOnSpot modal isolated, but the two
<button>s lack an explicittype, which is what Biome is flagging and can cause unintendedsubmitbehavior if this JSX ever sits inside a<form>.Apply this diff to fix both buttons:
- <button data-testid="add-onspot-close" onClick={handleClose}> + <button + type="button" + data-testid="add-onspot-close" + onClick={handleClose} + > Close Onspot </button> - <button data-testid="reload-members-btn" onClick={reloadMembers}> + <button + type="button" + data-testid="reload-members-btn" + onClick={reloadMembers} + > Reload Members </button>
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
CONTRIBUTING.mdis excluded by!*.md
📒 Files selected for processing (2)
scripts/githooks/check_pom.js(3 hunks)src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx(4 hunks)
🧰 Additional context used
🧠 Learnings (28)
📓 Common learnings
Learnt from: Chaitanya1672
Repo: PalisadoesFoundation/talawa-admin PR: 2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-10-08T16:13:41.996Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-12T00:28:53.713Z
Learning: In talawa-admin PR #4565 continuation (PR #4664 planned), Phase 2A mock isolation strategy uses global vi.clearAllMocks() in afterEach (vitest.setup.ts) plus refactoring module-level vi.fn() into per-test beforeEach blocks across 6 parallelizable issues (2A.0 foundation, 2A.1-2A.4 directory-based fixes, 2A.5 validation). This approach addresses mock call history accumulation enabling maxConcurrency: 2 and 2.3-2.5x speedup. vi.restoreAllMocks() alternative considered for spy restoration during validation phase. Phase 2A (mocks) correctly separated from Phase 2B (DOM/Apollo).
Learnt from: palisadoes
Repo: PalisadoesFoundation/talawa-admin PR: 4718
File: src/components/EventManagement/Dashboard/EventDashboard.mocks.ts:83-114
Timestamp: 2025-11-21T12:42:24.884Z
Learning: In talawa-admin mock files (e.g., EventDashboard.mocks.ts), mock constant names must accurately reflect what they test. Mock names suggesting role-based logic (e.g., MOCKS_WITH_ADMIN_ROLE) are misleading when the component derives role from localStorage rather than mock data. Name mocks based on their distinguishing data features (e.g., MOCKS_WITH_SINGLE_ATTENDEE) or test context (e.g., MOCKS_FOR_ADMIN_STORAGE_TEST).
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-11T11:51:09.236Z
Learning: In talawa-admin PR #4664 (continuation of PR #4565 sharding work), global mock cleanup was implemented via vi.clearAllMocks() in vitest.setup.ts afterEach, along with Apollo Client warning suppression (temporary, pending follow-up PR) and test suite refactoring to per-test StaticMockLink instances. This test isolation strategy addresses mock state leakage that forced maxConcurrency: 1 in PR #4565, enabling future parallel test execution improvements and 3-4x speedup potential.
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 2718
File: src/screens/UserPortal/Settings/Settings.spec.tsx:0-0
Timestamp: 2024-12-22T17:58:17.818Z
Learning: The matchMedia mock implementation in `Settings.spec.tsx` no longer includes the deprecated addListener and removeListener methods, opting solely for addEventListener and removeEventListener.
Learnt from: bitbard3
Repo: PalisadoesFoundation/talawa-admin PR: 2588
File: src/components/ChangeLanguageDropdown/ChangeLanguageDropdown.spec.tsx:145-155
Timestamp: 2024-12-02T04:20:11.745Z
Learning: In PRs focused solely on refactoring test cases from Jest to Vitest, avoid suggesting optimizations or changes outside the migration scope.
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/Requests/Requests.spec.tsx:0-0
Timestamp: 2025-10-22T22:22:27.696Z
Learning: In talawa-admin tests using react-infinite-scroll-component (e.g., src/screens/Requests/Requests.spec.tsx), jsdom scroll is flaky. Prefer a resilient approach: try querying the container via document.querySelector('[data-testid="infinite-scroll-component"]') and fall back to window scroll if missing. Strengthen assertions by checking for page-2 items (e.g., "User9 Test") to ensure fetchMore actually ran instead of relying only on row counts.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-01T16:34:10.347Z
Learning: In talawa-admin parallel test sharding (PR #4565), Bootstrap modals render via portals to document.body, causing screen.getByRole('dialog') to find dialogs from ALL concurrent test shards. Solution: use unique data-testid per modal instance and query within that scope using within() helper, or use findAllByTestId and take last element (less robust, timing-dependent).
📚 Learning: 2025-09-29T22:03:31.716Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 4240
File: cypress/pageObjects/AdminPortal/LeftDrawer.ts:2-12
Timestamp: 2025-09-29T22:03:31.716Z
Learning: In the talawa-admin project, when migrating Cypress tests to Page Object Model (POM), the maintainer syedali237 prefers to extract existing test logic without refactoring it, maintaining the original test behavior even if method names or assertions could be improved.
Applied to files:
scripts/githooks/check_pom.js
📚 Learning: 2025-08-17T07:39:34.255Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 4077
File: package.json:189-213
Timestamp: 2025-08-17T07:39:34.255Z
Learning: The Talawa Admin codebase primarily uses .spec.tsx/.spec.ts naming convention for unit tests, with Cypress tests using .cy.ts pattern. However, there is at least one .test.tsx file in the codebase, so NYC exclude patterns should include both .spec and .test patterns.
Applied to files:
scripts/githooks/check_pom.js
📚 Learning: 2024-12-09T15:54:04.872Z
Learnt from: MayankJha014
Repo: PalisadoesFoundation/talawa-admin PR: 2619
File: vitest.config.ts:0-0
Timestamp: 2024-12-09T15:54:04.872Z
Learning: The files `scripts/custom-test-env.js`, `src/utils/i18nForTest.ts`, and `vitest.setup.ts` are not test files and should not be included in the test pattern.
Applied to files:
scripts/githooks/check_pom.js
📚 Learning: 2025-11-21T12:42:24.884Z
Learnt from: palisadoes
Repo: PalisadoesFoundation/talawa-admin PR: 4718
File: src/components/EventManagement/Dashboard/EventDashboard.mocks.ts:83-114
Timestamp: 2025-11-21T12:42:24.884Z
Learning: In talawa-admin mock files (e.g., EventDashboard.mocks.ts), mock constant names must accurately reflect what they test. Mock names suggesting role-based logic (e.g., MOCKS_WITH_ADMIN_ROLE) are misleading when the component derives role from localStorage rather than mock data. Name mocks based on their distinguishing data features (e.g., MOCKS_WITH_SINGLE_ATTENDEE) or test context (e.g., MOCKS_FOR_ADMIN_STORAGE_TEST).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-08T16:13:41.996Z
Learnt from: Chaitanya1672
Repo: PalisadoesFoundation/talawa-admin PR: 2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-10-08T16:13:41.996Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-12-22T17:58:17.818Z
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 2718
File: src/screens/UserPortal/Settings/Settings.spec.tsx:0-0
Timestamp: 2024-12-22T17:58:17.818Z
Learning: The matchMedia mock implementation in `Settings.spec.tsx` no longer includes the deprecated addListener and removeListener methods, opting solely for addEventListener and removeEventListener.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-12T00:28:53.713Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-12T00:28:53.713Z
Learning: In talawa-admin PR #4565 continuation (PR #4664 planned), Phase 2A mock isolation strategy uses global vi.clearAllMocks() in afterEach (vitest.setup.ts) plus refactoring module-level vi.fn() into per-test beforeEach blocks across 6 parallelizable issues (2A.0 foundation, 2A.1-2A.4 directory-based fixes, 2A.5 validation). This approach addresses mock call history accumulation enabling maxConcurrency: 2 and 2.3-2.5x speedup. vi.restoreAllMocks() alternative considered for spy restoration during validation phase. Phase 2A (mocks) correctly separated from Phase 2B (DOM/Apollo).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T12:01:40.366Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/screens/ManageTag/ManageTagMockComponents/MockAddPeopleToTag.tsx:1-28
Timestamp: 2024-10-30T12:01:40.366Z
Learning: In the `MockAddPeopleToTag` component in `src/screens/ManageTag/ManageTagMockComponents/MockAddPeopleToTag.tsx`, it's acceptable to implement only the necessary props from `InterfaceAddPeopleToTagProps` and omit others like `refetchAssignedMembersData`, `t`, and `tCommon` that are tested separately.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-10-22T22:00:53.943Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts:0-0
Timestamp: 2025-10-22T22:00:53.943Z
Learning: In src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts (and similar mock files), avoid duplicating identical Apollo MockedProvider mocks for repeated query consumption. Prefer adding `maxUsageCount` to the existing mock or using `newData` for reusable responses to keep tests deterministic and reduce drift.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-11T11:51:09.236Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-11T11:51:09.236Z
Learning: In talawa-admin PR #4664 (continuation of PR #4565 sharding work), global mock cleanup was implemented via vi.clearAllMocks() in vitest.setup.ts afterEach, along with Apollo Client warning suppression (temporary, pending follow-up PR) and test suite refactoring to per-test StaticMockLink instances. This test isolation strategy addresses mock state leakage that forced maxConcurrency: 1 in PR #4565, enabling future parallel test execution improvements and 3-4x speedup potential.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:48:36.443Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/AddPeopleToTag/AddPeopleToTag.test.tsx:177-241
Timestamp: 2024-11-02T07:48:36.443Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.test.tsx`, prefer keeping test cases separate and more readable, even if it involves some duplication, instead of extracting common logic into helper functions.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-13T18:07:48.621Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-13T18:07:48.621Z
Learning: In talawa-admin, Apollo Client pinned to 3.11.10 (not 3.14.0) to avoid deprecation warnings during test isolation work (PR #4565 Phase 2A-2B). Apollo 3.14.0's MockedProvider internally uses deprecated options causing console noise that interferes with debugging. Upgrade to 4.x blocked by dependency conflicts with apollo-upload-client and apollo/link-error. All addTypename props removed from 115+ test files for future compatibility. Will upgrade when dependencies support Apollo 4.x.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-10-22T22:22:27.696Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/Requests/Requests.spec.tsx:0-0
Timestamp: 2025-10-22T22:22:27.696Z
Learning: In talawa-admin tests using react-infinite-scroll-component (e.g., src/screens/Requests/Requests.spec.tsx), jsdom scroll is flaky. Prefer a resilient approach: try querying the container via document.querySelector('[data-testid="infinite-scroll-component"]') and fall back to window scroll if missing. Strengthen assertions by checking for page-2 items (e.g., "User9 Test") to ensure fetchMore actually ran instead of relying only on row counts.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:45:57.175Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: In the talawa-admin project, the Advertisement component tests (3 files) use both ApolloProvider and MockedProvider together, though it's not a widespread pattern in the codebase. The maintainer has confirmed this approach is needed for these specific tests.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-26T12:32:45.867Z
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 3400
File: src/screens/UserPortal/Organizations/Organizations.spec.tsx:19-19
Timestamp: 2025-01-26T12:32:45.867Z
Learning: In React test files, avoid using React hooks outside component scope (including in static objects like mock data). Instead, initialize hooks inside describe blocks or extract the needed functionality without using hooks.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:45:57.175Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: Using both ApolloProvider and MockedProvider together in tests is an established pattern in this codebase, even though it's technically redundant from Apollo Client's best practices perspective.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-02-20T13:35:01.218Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3712
File: src/components/EventCalender/Yearly/YearlyEventCalender.spec.tsx:113-127
Timestamp: 2025-02-20T13:35:01.218Z
Learning: In React component tests, when testing window resize event handling, it's acceptable to only verify that the event is properly triggered without assertions if the test's focus is specifically on event handling rather than responsive behavior. Testing the actual responsive rendering would be a separate test case.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-03-11T17:45:54.621Z
Learnt from: PurnenduMIshra129th
Repo: PalisadoesFoundation/talawa-admin PR: 3814
File: src/components/UserPortal/OrganizationNavbar/OrganizationNavbar.spec.tsx:137-146
Timestamp: 2025-03-11T17:45:54.621Z
Learning: In OrganizationNavbar.spec.tsx, separate vi.mock implementations for react-router-dom are needed to avoid errors - one for useNavigate and another for useParams.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-11T07:47:39.266Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2425
File: src/screens/MemberDetail/MemberDetail.test.tsx:100-100
Timestamp: 2024-11-11T07:47:39.266Z
Learning: In `src/screens/MemberDetail/MemberDetail.test.tsx`, using `await wait();` is acceptable to wait for the render to complete.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-27T06:37:47.871Z
Learnt from: adithyanotfound
Repo: PalisadoesFoundation/talawa-admin PR: 2482
File: src/components/AddOn/support/components/Action/Action.spec.tsx:1-8
Timestamp: 2024-11-27T06:37:47.871Z
Learning: In the Talawa-Admin project, the `testing-library/jest-dom` package is imported globally in `vitest.setup.ts`, so individual test files do not need to import it separately.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T13:26:46.088Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/UserPortal/Volunteer/Actions/Actions.mocks.ts:3-119
Timestamp: 2024-11-01T13:26:46.088Z
Learning: In `src/screens/UserPortal/Volunteer/Actions/Actions.mocks.ts`, the `dueDate` fields in mock data do not determine any test process status, so using future dates is acceptable.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T12:54:20.857Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/OrganizationActionItems/testObject.mocks.ts:184-402
Timestamp: 2024-11-01T12:54:20.857Z
Learning: In `src/screens/OrganizationActionItems/testObject.mocks.ts`, test failures are not dependent on the `createdAt` fields; hardcoded dates in `createdAt` fields do not cause test failures in this file.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-17T22:18:09.680Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-17T22:18:09.680Z
Learning: Talawa Admin Phase 2A testing guideline: Allow vi.hoisted() + vi.mock() module-level mocks for shared dependencies; prefer afterEach(() => vi.clearAllMocks()) as default cleanup. Use afterEach(() => vi.restoreAllMocks()) only in suites that create vi.spyOn spies or patch real implementations. Avoid vi.resetAllMocks() globally. The generic “no module-level mocks” rule is updated to “no module-level vi.fn except vi.hoisted module mocks.”
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-01T16:34:10.347Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-01T16:34:10.347Z
Learning: In talawa-admin parallel test sharding (PR #4565), Bootstrap modals render via portals to document.body, causing screen.getByRole('dialog') to find dialogs from ALL concurrent test shards. Solution: use unique data-testid per modal instance and query within that scope using within() helper, or use findAllByTestId and take last element (less robust, timing-dependent).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-15T05:39:30.480Z
Learnt from: arpit-chakraborty
Repo: PalisadoesFoundation/talawa-admin PR: 3158
File: src/screens/OrganizationTags/OrganizationTagsMocks.ts:384-524
Timestamp: 2025-01-15T05:39:30.480Z
Learning: In OrganizationTagsMocks.ts, MOCKS_NULL_END_CURSOR and MOCKS_NO_MORE_PAGES are designed to test UI handling of edge cases where pagination data is inconsistent (e.g., hasNextPage is true but endCursor is null, or next page returns undefined data).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-25T19:31:37.405Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2355
File: src/screens/ManageTag/ManageTagMocks.ts:187-269
Timestamp: 2024-10-25T19:31:37.405Z
Learning: In `src/screens/ManageTag/ManageTagMocks.ts`, when mocking data for `USER_TAGS_ASSIGNED_MEMBERS` and `USER_TAGS_MEMBERS_TO_ASSIGN_TO`, it's acceptable for user IDs to overlap because the queries serve different purposes and the overlapping IDs can represent realistic scenarios in tests.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-28T06:33:09.726Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2362
File: src/components/TagActions/TagActions.test.tsx:251-274
Timestamp: 2024-10-28T06:33:09.726Z
Learning: In `TagActions.test.tsx`, negative test cases for tag operations can be deferred and added later if necessary, according to the team's plan.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
🧬 Code graph analysis (1)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (2)
src/GraphQl/Queries/Queries.ts (3)
EVENT_ATTENDEES(316-334)MEMBERS_LIST(808-820)EVENT_DETAILS(248-285)src/state/store.ts (1)
store(4-6)
🪛 Biome (2.1.2)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
[error] 36-36: Provide an explicit type prop for the button element.
The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
(lint/a11y/useButtonType)
[error] 39-39: Provide an explicit type prop for the button element.
The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
(lint/a11y/useButtonType)
[error] 67-67: Provide an explicit type prop for the button element.
The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
(lint/a11y/useButtonType)
[error] 71-71: Provide an explicit type prop for the button element.
The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
(lint/a11y/useButtonType)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Check Python Code Style
- GitHub Check: Generate and Validate Documentation
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (11)
scripts/githooks/check_pom.js (3)
54-54: String quoting normalized to single quotes.The refactoring consistently applies single quotes throughout the file, improving style consistency. No functional impact.
Also applies to: 64-66, 69-69
1-70: Logic and behavior correctly preserved through refactoring.The core POM validation logic remains unchanged: file discovery, pattern matching, error reporting, and exit codes all function identically. The refactoring is focused on modernizing imports and normalizing code style.
17-18: Verification Complete:globSyncImport is CorrectThe web search confirms that glob v13.0.0 exports
globSyncas a named export. The import statementimport { globSync } from 'glob'on line 18 and its usage on line 49 are both valid and compatible with glob v13.0.0.src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (8)
2-22: Imports and base test setup look goodUsing
MockedResponsefor the Apollo mocks and centralizingrender,fireEvent, andwaitForfrom@testing-library/reactis clean and keeps the spec strongly typed. No issues here.
247-259: Base render test gives good smoke coverageThis test neatly verifies that the modal title and the Autocomplete mount once queries resolve, covering the non‑recurring EVENT_DETAILS branch plus attendees/members fetch. Looks good.
282-300: Validation warning test is straightforward and clearThe flow of opening the modal, clicking “Add Registrant” with no selection, and asserting the warning text fully exercises the validation branch. Nicely scoped.
330-356: Error path for the mutation is mirrored cleanlyThis test mirrors the success path but drives the
makeAddRegistrantErrorMockto assert the error toast, which is exactly what we want for negative coverage. Implementation looks solid.
358-384: RecurringisRecurringbranch is exercised correctlyBy swapping in
makeEventDetailsRecurringMockand the recurring variant of the mutation mock, this test ensures theisRecurringlogic and therecurringEventInstanceIdvariables path are covered. Assertions on both loading and success messages confirm the branch works end‑to‑end.
386-427: Nice coverage ofnoOptionsTextand AddOnSpot reload/close behaviorThis test thoroughly covers the “no members found” state and the AddOnSpot modal interactions:
- Drives the Autocomplete into the
noOptionsTextbranch.- Opens the AddOnSpot mock modal.
- Clicks
reloadMembers(backed by the second attendees mock).- Closes the modal and asserts it’s gone.
Good use of the dedicated mocks to keep this flow deterministic.
429-455: Invite by Email modal open/close behavior is well validatedThe test confirms:
- The InviteByEmail modal opens when the button is clicked.
- The correct
eventIdandisRecurring=falseprops are wired through.handleClosefrom the parent closes the modal.Clean, behavior‑focused coverage; no changes needed.
481-500:getOptionLabel“Unknown User” fallback is nicely exercisedThis test does a good job of explicitly opening the Autocomplete dropdown and asserting the “Unknown User” label, which directly targets the fallback branch in
getOptionLabel. It’s precise and should guard well against regressions in the label logic.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (1)
140-160: Fix field name to match query schemaThe
MEMBERS_LISTquery expectsemailAddress(persrc/GraphQl/Queries/Queries.tslines 807-819), but this mock uses{ id: 'user2', name: '', - email: 'unknown@example.com', + emailAddress: 'unknown@example.com', role: 'member', avatarURL: null, createdAt: '2023-01-01', updatedAt: '2023-01-01', },
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx(4 hunks)
🧰 Additional context used
🧠 Learnings (39)
📓 Common learnings
Learnt from: Chaitanya1672
Repo: PalisadoesFoundation/talawa-admin PR: 2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-10-08T16:13:41.996Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-12T00:28:53.713Z
Learning: In talawa-admin PR #4565 continuation (PR #4664 planned), Phase 2A mock isolation strategy uses global vi.clearAllMocks() in afterEach (vitest.setup.ts) plus refactoring module-level vi.fn() into per-test beforeEach blocks across 6 parallelizable issues (2A.0 foundation, 2A.1-2A.4 directory-based fixes, 2A.5 validation). This approach addresses mock call history accumulation enabling maxConcurrency: 2 and 2.3-2.5x speedup. vi.restoreAllMocks() alternative considered for spy restoration during validation phase. Phase 2A (mocks) correctly separated from Phase 2B (DOM/Apollo).
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-11T11:51:09.236Z
Learning: In talawa-admin PR #4664 (continuation of PR #4565 sharding work), global mock cleanup was implemented via vi.clearAllMocks() in vitest.setup.ts afterEach, along with Apollo Client warning suppression (temporary, pending follow-up PR) and test suite refactoring to per-test StaticMockLink instances. This test isolation strategy addresses mock state leakage that forced maxConcurrency: 1 in PR #4565, enabling future parallel test execution improvements and 3-4x speedup potential.
Learnt from: palisadoes
Repo: PalisadoesFoundation/talawa-admin PR: 4718
File: src/components/EventManagement/Dashboard/EventDashboard.mocks.ts:83-114
Timestamp: 2025-11-21T12:42:24.884Z
Learning: In talawa-admin mock files (e.g., EventDashboard.mocks.ts), mock constant names must accurately reflect what they test. Mock names suggesting role-based logic (e.g., MOCKS_WITH_ADMIN_ROLE) are misleading when the component derives role from localStorage rather than mock data. Name mocks based on their distinguishing data features (e.g., MOCKS_WITH_SINGLE_ATTENDEE) or test context (e.g., MOCKS_FOR_ADMIN_STORAGE_TEST).
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 3400
File: src/screens/UserPortal/Organizations/Organizations.spec.tsx:19-19
Timestamp: 2025-01-26T12:32:45.867Z
Learning: In React test files, avoid using React hooks outside component scope (including in static objects like mock data). Instead, initialize hooks inside describe blocks or extract the needed functionality without using hooks.
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts:0-0
Timestamp: 2025-10-22T22:00:53.943Z
Learning: In src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts (and similar mock files), avoid duplicating identical Apollo MockedProvider mocks for repeated query consumption. Prefer adding `maxUsageCount` to the existing mock or using `newData` for reusable responses to keep tests deterministic and reduce drift.
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/AddPeopleToTag/AddPeopleToTag.test.tsx:177-241
Timestamp: 2024-11-02T07:48:36.443Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.test.tsx`, prefer keeping test cases separate and more readable, even if it involves some duplication, instead of extracting common logic into helper functions.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-13T18:07:48.621Z
Learning: In talawa-admin, Apollo Client pinned to 3.11.10 (not 3.14.0) to avoid deprecation warnings during test isolation work (PR #4565 Phase 2A-2B). Apollo 3.14.0's MockedProvider internally uses deprecated options causing console noise that interferes with debugging. Upgrade to 4.x blocked by dependency conflicts with apollo-upload-client and apollo/link-error. All addTypename props removed from 115+ test files for future compatibility. Will upgrade when dependencies support Apollo 4.x.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-01T16:34:10.347Z
Learning: In talawa-admin parallel test sharding (PR #4565), Bootstrap modals render via portals to document.body, causing screen.getByRole('dialog') to find dialogs from ALL concurrent test shards. Solution: use unique data-testid per modal instance and query within that scope using within() helper, or use findAllByTestId and take last element (less robust, timing-dependent).
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: In the talawa-admin project, the Advertisement component tests (3 files) use both ApolloProvider and MockedProvider together, though it's not a widespread pattern in the codebase. The maintainer has confirmed this approach is needed for these specific tests.
📚 Learning: 2025-11-21T12:42:24.884Z
Learnt from: palisadoes
Repo: PalisadoesFoundation/talawa-admin PR: 4718
File: src/components/EventManagement/Dashboard/EventDashboard.mocks.ts:83-114
Timestamp: 2025-11-21T12:42:24.884Z
Learning: In talawa-admin mock files (e.g., EventDashboard.mocks.ts), mock constant names must accurately reflect what they test. Mock names suggesting role-based logic (e.g., MOCKS_WITH_ADMIN_ROLE) are misleading when the component derives role from localStorage rather than mock data. Name mocks based on their distinguishing data features (e.g., MOCKS_WITH_SINGLE_ATTENDEE) or test context (e.g., MOCKS_FOR_ADMIN_STORAGE_TEST).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-27T11:40:30.717Z
Learnt from: rawadhossain
Repo: PalisadoesFoundation/talawa-admin PR: 4865
File: src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx:261-280
Timestamp: 2025-11-27T11:40:30.717Z
Learning: In Talawa Admin tests (e.g., src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx), react-bootstrap Modal header close buttons don't support custom test IDs, so using getAllByRole('button', { name: /close/i })[0] to select the modal's primary close action is acceptable and stable, as the Modal component consistently exposes "Close" as the accessible label.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-12-22T17:58:17.818Z
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 2718
File: src/screens/UserPortal/Settings/Settings.spec.tsx:0-0
Timestamp: 2024-12-22T17:58:17.818Z
Learning: The matchMedia mock implementation in `Settings.spec.tsx` no longer includes the deprecated addListener and removeListener methods, opting solely for addEventListener and removeEventListener.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-08T16:13:41.996Z
Learnt from: Chaitanya1672
Repo: PalisadoesFoundation/talawa-admin PR: 2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-10-08T16:13:41.996Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T12:01:40.366Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/screens/ManageTag/ManageTagMockComponents/MockAddPeopleToTag.tsx:1-28
Timestamp: 2024-10-30T12:01:40.366Z
Learning: In the `MockAddPeopleToTag` component in `src/screens/ManageTag/ManageTagMockComponents/MockAddPeopleToTag.tsx`, it's acceptable to implement only the necessary props from `InterfaceAddPeopleToTagProps` and omit others like `refetchAssignedMembersData`, `t`, and `tCommon` that are tested separately.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-27T11:41:54.834Z
Learnt from: rawadhossain
Repo: PalisadoesFoundation/talawa-admin PR: 4865
File: src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx:302-328
Timestamp: 2025-11-27T11:41:54.834Z
Learning: In Talawa Admin tests (e.g., src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx), using queryByLabelText with an HTMLElement cast for MUI Autocomplete inputs is acceptable because the Autocomplete input can mount asynchronously and isn't always available for strict getBy* queries at initial render. This pattern is stable for MUI Autocomplete components.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-12T00:28:53.713Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-12T00:28:53.713Z
Learning: In talawa-admin PR #4565 continuation (PR #4664 planned), Phase 2A mock isolation strategy uses global vi.clearAllMocks() in afterEach (vitest.setup.ts) plus refactoring module-level vi.fn() into per-test beforeEach blocks across 6 parallelizable issues (2A.0 foundation, 2A.1-2A.4 directory-based fixes, 2A.5 validation). This approach addresses mock call history accumulation enabling maxConcurrency: 2 and 2.3-2.5x speedup. vi.restoreAllMocks() alternative considered for spy restoration during validation phase. Phase 2A (mocks) correctly separated from Phase 2B (DOM/Apollo).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-10-22T22:00:53.943Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts:0-0
Timestamp: 2025-10-22T22:00:53.943Z
Learning: In src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts (and similar mock files), avoid duplicating identical Apollo MockedProvider mocks for repeated query consumption. Prefer adding `maxUsageCount` to the existing mock or using `newData` for reusable responses to keep tests deterministic and reduce drift.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-11T11:51:09.236Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-11T11:51:09.236Z
Learning: In talawa-admin PR #4664 (continuation of PR #4565 sharding work), global mock cleanup was implemented via vi.clearAllMocks() in vitest.setup.ts afterEach, along with Apollo Client warning suppression (temporary, pending follow-up PR) and test suite refactoring to per-test StaticMockLink instances. This test isolation strategy addresses mock state leakage that forced maxConcurrency: 1 in PR #4565, enabling future parallel test execution improvements and 3-4x speedup potential.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:48:36.443Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/AddPeopleToTag/AddPeopleToTag.test.tsx:177-241
Timestamp: 2024-11-02T07:48:36.443Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.test.tsx`, prefer keeping test cases separate and more readable, even if it involves some duplication, instead of extracting common logic into helper functions.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-02-09T06:22:23.028Z
Learnt from: adithyanotfound
Repo: PalisadoesFoundation/talawa-admin PR: 3569
File: src/screens/UserPortal/Settings/Settings.spec.tsx:314-316
Timestamp: 2025-02-09T06:22:23.028Z
Learning: In the Settings component's tests, `fireEvent.change` should be used instead of `userEvent.type` for the address input field, as `userEvent` doesn't work correctly in this case.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-08-13T06:52:48.055Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 4040
File: cypress/pageObjects/AdminPortal/PeoplePage.ts:30-34
Timestamp: 2025-08-13T06:52:48.055Z
Learning: In the talawa-admin project's Cypress tests, specifically in cypress/pageObjects/AdminPortal/PeoplePage.ts, the element '[data-testid="existingUser"]' is a toggle control that requires .trigger('click') instead of .click() because it's not a standard button but a custom UI component that needs direct event triggering.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:31:50.788Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/TagActions/TagActions.tsx:216-0
Timestamp: 2024-11-02T07:31:50.788Z
Learning: In `src/components/TagActions/TagActions.tsx`, the submit button should not be disabled when no tags are selected, as per the design preference.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T13:26:46.088Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/UserPortal/Volunteer/Actions/Actions.mocks.ts:3-119
Timestamp: 2024-11-01T13:26:46.088Z
Learning: In `src/screens/UserPortal/Volunteer/Actions/Actions.mocks.ts`, the `dueDate` fields in mock data do not determine any test process status, so using future dates is acceptable.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-17T22:18:09.680Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-17T22:18:09.680Z
Learning: Talawa Admin Phase 2A testing guideline: Allow vi.hoisted() + vi.mock() module-level mocks for shared dependencies; prefer afterEach(() => vi.clearAllMocks()) as default cleanup. Use afterEach(() => vi.restoreAllMocks()) only in suites that create vi.spyOn spies or patch real implementations. Avoid vi.resetAllMocks() globally. The generic “no module-level mocks” rule is updated to “no module-level vi.fn except vi.hoisted module mocks.”
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-13T18:07:48.621Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-13T18:07:48.621Z
Learning: In talawa-admin, Apollo Client pinned to 3.11.10 (not 3.14.0) to avoid deprecation warnings during test isolation work (PR #4565 Phase 2A-2B). Apollo 3.14.0's MockedProvider internally uses deprecated options causing console noise that interferes with debugging. Upgrade to 4.x blocked by dependency conflicts with apollo-upload-client and apollo/link-error. All addTypename props removed from 115+ test files for future compatibility. Will upgrade when dependencies support Apollo 4.x.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-03-11T17:45:54.621Z
Learnt from: PurnenduMIshra129th
Repo: PalisadoesFoundation/talawa-admin PR: 3814
File: src/components/UserPortal/OrganizationNavbar/OrganizationNavbar.spec.tsx:137-146
Timestamp: 2025-03-11T17:45:54.621Z
Learning: In OrganizationNavbar.spec.tsx, separate vi.mock implementations for react-router-dom are needed to avoid errors - one for useNavigate and another for useParams.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:45:57.175Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: In the talawa-admin project, the Advertisement component tests (3 files) use both ApolloProvider and MockedProvider together, though it's not a widespread pattern in the codebase. The maintainer has confirmed this approach is needed for these specific tests.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:45:57.175Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: Using both ApolloProvider and MockedProvider together in tests is an established pattern in this codebase, even though it's technically redundant from Apollo Client's best practices perspective.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-26T12:32:45.867Z
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 3400
File: src/screens/UserPortal/Organizations/Organizations.spec.tsx:19-19
Timestamp: 2025-01-26T12:32:45.867Z
Learning: In React test files, avoid using React hooks outside component scope (including in static objects like mock data). Instead, initialize hooks inside describe blocks or extract the needed functionality without using hooks.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-10-22T22:22:27.696Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/Requests/Requests.spec.tsx:0-0
Timestamp: 2025-10-22T22:22:27.696Z
Learning: In talawa-admin tests using react-infinite-scroll-component (e.g., src/screens/Requests/Requests.spec.tsx), jsdom scroll is flaky. Prefer a resilient approach: try querying the container via document.querySelector('[data-testid="infinite-scroll-component"]') and fall back to window scroll if missing. Strengthen assertions by checking for page-2 items (e.g., "User9 Test") to ensure fetchMore actually ran instead of relying only on row counts.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-02-20T13:35:01.218Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3712
File: src/components/EventCalender/Yearly/YearlyEventCalender.spec.tsx:113-127
Timestamp: 2025-02-20T13:35:01.218Z
Learning: In React component tests, when testing window resize event handling, it's acceptable to only verify that the event is properly triggered without assertions if the test's focus is specifically on event handling rather than responsive behavior. Testing the actual responsive rendering would be a separate test case.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-01T16:34:10.347Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-01T16:34:10.347Z
Learning: In talawa-admin parallel test sharding (PR #4565), Bootstrap modals render via portals to document.body, causing screen.getByRole('dialog') to find dialogs from ALL concurrent test shards. Solution: use unique data-testid per modal instance and query within that scope using within() helper, or use findAllByTestId and take last element (less robust, timing-dependent).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-28T06:38:43.765Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2362
File: src/components/TagActions/TagActions.test.tsx:123-131
Timestamp: 2024-10-28T06:38:43.765Z
Learning: In `TagActions.test.tsx`, `link2` is the error link used to simulate errors, so the existing test cases sufficiently cover error handling.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-28T06:33:09.726Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2362
File: src/components/TagActions/TagActions.test.tsx:251-274
Timestamp: 2024-10-28T06:33:09.726Z
Learning: In `TagActions.test.tsx`, negative test cases for tag operations can be deferred and added later if necessary, according to the team's plan.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-08T16:13:41.996Z
Learnt from: Doraemon012
Repo: PalisadoesFoundation/talawa-admin PR: 1988
File: src/screens/MemberDetail/MemberDetail.test.tsx:170-195
Timestamp: 2024-10-08T16:13:41.996Z
Learning: In unit tests for this project, direct `click()` calls are acceptable; avoid suggesting replacing them with `userEvent.click()`.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T11:57:55.067Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/components/InfiniteScrollLoader/InfiniteScrollLoader.test.tsx:5-14
Timestamp: 2024-10-30T11:57:55.067Z
Learning: Currently, the developer considers the existing test coverage for the `InfiniteScrollLoader` component sufficient and prefers not to expand it at this time.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T12:54:20.857Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/OrganizationActionItems/testObject.mocks.ts:184-402
Timestamp: 2024-11-01T12:54:20.857Z
Learning: In `src/screens/OrganizationActionItems/testObject.mocks.ts`, test failures are not dependent on the `createdAt` fields; hardcoded dates in `createdAt` fields do not cause test failures in this file.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-25T19:31:37.405Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2355
File: src/screens/ManageTag/ManageTagMocks.ts:187-269
Timestamp: 2024-10-25T19:31:37.405Z
Learning: In `src/screens/ManageTag/ManageTagMocks.ts`, when mocking data for `USER_TAGS_ASSIGNED_MEMBERS` and `USER_TAGS_MEMBERS_TO_ASSIGN_TO`, it's acceptable for user IDs to overlap because the queries serve different purposes and the overlapping IDs can represent realistic scenarios in tests.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-06T05:15:51.829Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-06T05:15:51.829Z
Learning: In talawa-admin PR #4565, test sharding implementation achieved 2x speedup (8min → 4min) with conservative settings (maxConcurrency: 1, concurrent: false, maxThreads: 2 in CI) due to test isolation issues across 269 test files. These settings prevent OOM and race conditions. Higher speedup (3-4x) is achievable but requires systematic test isolation improvements. Apollo Client addTypename={false} deprecation warnings (142 files) are suppressed with TODO for follow-up fixes.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:41:55.660Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/Advertisements.spec.tsx:316-327
Timestamp: 2025-04-20T06:41:55.660Z
Learning: In the Talawa Admin project's test files, button click events may trigger asynchronous operations that require awaiting the act() call, even when using fireEvent.click() which is typically synchronous.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-07-11T20:14:07.922Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3988
File: cypress/pageObjects/AdminPortal/AdminDashboard.ts:4-5
Timestamp: 2025-07-11T20:14:07.922Z
Learning: In the talawa-admin project, mixing `data-cy` and `data-testid` attributes in Cypress selectors may be necessary due to technical constraints where UI library components have built-in `data-testid` attributes but don't support adding custom `data-cy` attributes.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-07-12T19:56:14.106Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3988
File: cypress/support/commands.ts:42-46
Timestamp: 2025-07-12T19:56:14.106Z
Learning: In the talawa-admin project, the toast notification component is a built-in component that doesn't support adding custom data-cy attributes. When testing toast messages in Cypress, use the `[role=alert]` selector combined with `contain.text` assertions to verify the expected message content, which works correctly even when multiple toasts are displayed simultaneously.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T15:46:05.784Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/components/AddPeopleToTag/AddPeopleToTag.tsx:78-104
Timestamp: 2024-10-30T15:46:05.784Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.tsx`, and similar components, the team prefers to keep the current implementation of the `updateQuery` logic in infinite scroll functionality consistent across all screens.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:39:51.950Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/screens/ManageTag/ManageTag.tsx:108-0
Timestamp: 2024-11-02T07:39:51.950Z
Learning: In `src/screens/ManageTag/ManageTag.tsx`, when `assignedMemberSearchFirstName` or `assignedMemberSearchLastName` are empty strings, the query in the `useQuery` for `USER_TAGS_ASSIGNED_MEMBERS` intentionally includes filters with empty strings to match all entries.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-12-02T04:20:11.745Z
Learnt from: bitbard3
Repo: PalisadoesFoundation/talawa-admin PR: 2588
File: src/components/ChangeLanguageDropdown/ChangeLanguageDropdown.spec.tsx:145-155
Timestamp: 2024-12-02T04:20:11.745Z
Learning: In PRs focused solely on refactoring test cases from Jest to Vitest, avoid suggesting optimizations or changes outside the migration scope.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-11T07:47:39.266Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2425
File: src/screens/MemberDetail/MemberDetail.test.tsx:100-100
Timestamp: 2024-11-11T07:47:39.266Z
Learning: In `src/screens/MemberDetail/MemberDetail.test.tsx`, using `await wait();` is acceptable to wait for the render to complete.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-15T05:39:30.480Z
Learnt from: arpit-chakraborty
Repo: PalisadoesFoundation/talawa-admin PR: 3158
File: src/screens/OrganizationTags/OrganizationTagsMocks.ts:384-524
Timestamp: 2025-01-15T05:39:30.480Z
Learning: In OrganizationTagsMocks.ts, MOCKS_NULL_END_CURSOR and MOCKS_NO_MORE_PAGES are designed to test UI handling of edge cases where pagination data is inconsistent (e.g., hasNextPage is true but endCursor is null, or next page returns undefined data).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
🧬 Code graph analysis (1)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (3)
src/GraphQl/Queries/Queries.ts (3)
EVENT_ATTENDEES(316-334)MEMBERS_LIST(808-820)EVENT_DETAILS(248-285)src/state/store.ts (1)
store(4-6)src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.tsx (1)
EventRegistrantsModal(65-209)
🪛 Biome (2.1.2)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
[error] 36-36: Provide an explicit type prop for the button element.
The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
(lint/a11y/useButtonType)
[error] 39-39: Provide an explicit type prop for the button element.
The default type of a button is submit, which causes the submission of a form when placed inside a form element. This is likely not the behaviour that you want inside a React application.
Allowed button types are: submit, button or reset
(lint/a11y/useButtonType)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Check Python Code Style
- GitHub Check: Generate and Validate Documentation
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (2)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (2)
253-265: Test suite is well-structured with comprehensive coverageThe test suite effectively covers:
- Basic rendering and element availability
- Modal close interactions
- Validation warnings for missing selections
- Non-recurring and recurring event flows with correct variable branching
- Error handling for mutation failures
- Nested modal interactions (AddOnSpotAttendee, InviteByEmailModal)
getOptionLabelfallback to "Unknown User"The use of inline
vi.fn()for the handleClose test (line 268) aligns with Phase 2A mock isolation guidelines. Based on learnings, thequeryByLabelTextwith cast pattern for MUI Autocomplete is acceptable.
392-433: Good use of duplicate mock for refetch consumptionThe duplicate
makeAttendeesEmptyMock()at line 398 correctly handles Apollo's mock consumption behavior whenreloadMemberstriggersattendeesRefetch(). This pattern aligns with the project convention of providing sufficient mocks for repeated query consumption.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx(4 hunks)
🧰 Additional context used
🧠 Learnings (40)
📓 Common learnings
Learnt from: Chaitanya1672
Repo: PalisadoesFoundation/talawa-admin PR: 2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-10-08T16:13:41.996Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-12T00:28:53.713Z
Learning: In talawa-admin PR #4565 continuation (PR #4664 planned), Phase 2A mock isolation strategy uses global vi.clearAllMocks() in afterEach (vitest.setup.ts) plus refactoring module-level vi.fn() into per-test beforeEach blocks across 6 parallelizable issues (2A.0 foundation, 2A.1-2A.4 directory-based fixes, 2A.5 validation). This approach addresses mock call history accumulation enabling maxConcurrency: 2 and 2.3-2.5x speedup. vi.restoreAllMocks() alternative considered for spy restoration during validation phase. Phase 2A (mocks) correctly separated from Phase 2B (DOM/Apollo).
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-11T11:51:09.236Z
Learning: In talawa-admin PR #4664 (continuation of PR #4565 sharding work), global mock cleanup was implemented via vi.clearAllMocks() in vitest.setup.ts afterEach, along with Apollo Client warning suppression (temporary, pending follow-up PR) and test suite refactoring to per-test StaticMockLink instances. This test isolation strategy addresses mock state leakage that forced maxConcurrency: 1 in PR #4565, enabling future parallel test execution improvements and 3-4x speedup potential.
Learnt from: palisadoes
Repo: PalisadoesFoundation/talawa-admin PR: 4718
File: src/components/EventManagement/Dashboard/EventDashboard.mocks.ts:83-114
Timestamp: 2025-11-21T12:42:24.884Z
Learning: In talawa-admin mock files (e.g., EventDashboard.mocks.ts), mock constant names must accurately reflect what they test. Mock names suggesting role-based logic (e.g., MOCKS_WITH_ADMIN_ROLE) are misleading when the component derives role from localStorage rather than mock data. Name mocks based on their distinguishing data features (e.g., MOCKS_WITH_SINGLE_ATTENDEE) or test context (e.g., MOCKS_FOR_ADMIN_STORAGE_TEST).
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts:0-0
Timestamp: 2025-10-22T22:00:53.943Z
Learning: In src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts (and similar mock files), avoid duplicating identical Apollo MockedProvider mocks for repeated query consumption. Prefer adding `maxUsageCount` to the existing mock or using `newData` for reusable responses to keep tests deterministic and reduce drift.
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 2718
File: src/screens/UserPortal/Settings/Settings.spec.tsx:0-0
Timestamp: 2024-12-22T17:58:17.818Z
Learning: The matchMedia mock implementation in `Settings.spec.tsx` no longer includes the deprecated addListener and removeListener methods, opting solely for addEventListener and removeEventListener.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-13T18:07:48.621Z
Learning: In talawa-admin, Apollo Client pinned to 3.11.10 (not 3.14.0) to avoid deprecation warnings during test isolation work (PR #4565 Phase 2A-2B). Apollo 3.14.0's MockedProvider internally uses deprecated options causing console noise that interferes with debugging. Upgrade to 4.x blocked by dependency conflicts with apollo-upload-client and apollo/link-error. All addTypename props removed from 115+ test files for future compatibility. Will upgrade when dependencies support Apollo 4.x.
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: In the talawa-admin project, the Advertisement component tests (3 files) use both ApolloProvider and MockedProvider together, though it's not a widespread pattern in the codebase. The maintainer has confirmed this approach is needed for these specific tests.
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 3400
File: src/screens/UserPortal/Organizations/Organizations.spec.tsx:19-19
Timestamp: 2025-01-26T12:32:45.867Z
Learning: In React test files, avoid using React hooks outside component scope (including in static objects like mock data). Instead, initialize hooks inside describe blocks or extract the needed functionality without using hooks.
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/AddPeopleToTag/AddPeopleToTag.test.tsx:177-241
Timestamp: 2024-11-02T07:48:36.443Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.test.tsx`, prefer keeping test cases separate and more readable, even if it involves some duplication, instead of extracting common logic into helper functions.
📚 Learning: 2025-11-21T12:42:24.884Z
Learnt from: palisadoes
Repo: PalisadoesFoundation/talawa-admin PR: 4718
File: src/components/EventManagement/Dashboard/EventDashboard.mocks.ts:83-114
Timestamp: 2025-11-21T12:42:24.884Z
Learning: In talawa-admin mock files (e.g., EventDashboard.mocks.ts), mock constant names must accurately reflect what they test. Mock names suggesting role-based logic (e.g., MOCKS_WITH_ADMIN_ROLE) are misleading when the component derives role from localStorage rather than mock data. Name mocks based on their distinguishing data features (e.g., MOCKS_WITH_SINGLE_ATTENDEE) or test context (e.g., MOCKS_FOR_ADMIN_STORAGE_TEST).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-27T11:40:30.717Z
Learnt from: rawadhossain
Repo: PalisadoesFoundation/talawa-admin PR: 4865
File: src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx:261-280
Timestamp: 2025-11-27T11:40:30.717Z
Learning: In Talawa Admin tests (e.g., src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx), react-bootstrap Modal header close buttons don't support custom test IDs, so using getAllByRole('button', { name: /close/i })[0] to select the modal's primary close action is acceptable and stable, as the Modal component consistently exposes "Close" as the accessible label.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-12-22T17:58:17.818Z
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 2718
File: src/screens/UserPortal/Settings/Settings.spec.tsx:0-0
Timestamp: 2024-12-22T17:58:17.818Z
Learning: The matchMedia mock implementation in `Settings.spec.tsx` no longer includes the deprecated addListener and removeListener methods, opting solely for addEventListener and removeEventListener.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-08T16:13:41.996Z
Learnt from: Chaitanya1672
Repo: PalisadoesFoundation/talawa-admin PR: 2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-10-08T16:13:41.996Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T12:01:40.366Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/screens/ManageTag/ManageTagMockComponents/MockAddPeopleToTag.tsx:1-28
Timestamp: 2024-10-30T12:01:40.366Z
Learning: In the `MockAddPeopleToTag` component in `src/screens/ManageTag/ManageTagMockComponents/MockAddPeopleToTag.tsx`, it's acceptable to implement only the necessary props from `InterfaceAddPeopleToTagProps` and omit others like `refetchAssignedMembersData`, `t`, and `tCommon` that are tested separately.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-10-22T22:00:53.943Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts:0-0
Timestamp: 2025-10-22T22:00:53.943Z
Learning: In src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts (and similar mock files), avoid duplicating identical Apollo MockedProvider mocks for repeated query consumption. Prefer adding `maxUsageCount` to the existing mock or using `newData` for reusable responses to keep tests deterministic and reduce drift.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-27T11:41:54.834Z
Learnt from: rawadhossain
Repo: PalisadoesFoundation/talawa-admin PR: 4865
File: src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx:302-328
Timestamp: 2025-11-27T11:41:54.834Z
Learning: In Talawa Admin tests (e.g., src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx), using queryByLabelText with an HTMLElement cast for MUI Autocomplete inputs is acceptable because the Autocomplete input can mount asynchronously and isn't always available for strict getBy* queries at initial render. This pattern is stable for MUI Autocomplete components.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-11T11:51:09.236Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-11T11:51:09.236Z
Learning: In talawa-admin PR #4664 (continuation of PR #4565 sharding work), global mock cleanup was implemented via vi.clearAllMocks() in vitest.setup.ts afterEach, along with Apollo Client warning suppression (temporary, pending follow-up PR) and test suite refactoring to per-test StaticMockLink instances. This test isolation strategy addresses mock state leakage that forced maxConcurrency: 1 in PR #4565, enabling future parallel test execution improvements and 3-4x speedup potential.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-12T00:28:53.713Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-12T00:28:53.713Z
Learning: In talawa-admin PR #4565 continuation (PR #4664 planned), Phase 2A mock isolation strategy uses global vi.clearAllMocks() in afterEach (vitest.setup.ts) plus refactoring module-level vi.fn() into per-test beforeEach blocks across 6 parallelizable issues (2A.0 foundation, 2A.1-2A.4 directory-based fixes, 2A.5 validation). This approach addresses mock call history accumulation enabling maxConcurrency: 2 and 2.3-2.5x speedup. vi.restoreAllMocks() alternative considered for spy restoration during validation phase. Phase 2A (mocks) correctly separated from Phase 2B (DOM/Apollo).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-01T16:34:10.347Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-01T16:34:10.347Z
Learning: In talawa-admin parallel test sharding (PR #4565), Bootstrap modals render via portals to document.body, causing screen.getByRole('dialog') to find dialogs from ALL concurrent test shards. Solution: use unique data-testid per modal instance and query within that scope using within() helper, or use findAllByTestId and take last element (less robust, timing-dependent).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-02-09T06:22:23.028Z
Learnt from: adithyanotfound
Repo: PalisadoesFoundation/talawa-admin PR: 3569
File: src/screens/UserPortal/Settings/Settings.spec.tsx:314-316
Timestamp: 2025-02-09T06:22:23.028Z
Learning: In the Settings component's tests, `fireEvent.change` should be used instead of `userEvent.type` for the address input field, as `userEvent` doesn't work correctly in this case.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-08-13T06:52:48.055Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 4040
File: cypress/pageObjects/AdminPortal/PeoplePage.ts:30-34
Timestamp: 2025-08-13T06:52:48.055Z
Learning: In the talawa-admin project's Cypress tests, specifically in cypress/pageObjects/AdminPortal/PeoplePage.ts, the element '[data-testid="existingUser"]' is a toggle control that requires .trigger('click') instead of .click() because it's not a standard button but a custom UI component that needs direct event triggering.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:31:50.788Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/TagActions/TagActions.tsx:216-0
Timestamp: 2024-11-02T07:31:50.788Z
Learning: In `src/components/TagActions/TagActions.tsx`, the submit button should not be disabled when no tags are selected, as per the design preference.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T13:26:46.088Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/UserPortal/Volunteer/Actions/Actions.mocks.ts:3-119
Timestamp: 2024-11-01T13:26:46.088Z
Learning: In `src/screens/UserPortal/Volunteer/Actions/Actions.mocks.ts`, the `dueDate` fields in mock data do not determine any test process status, so using future dates is acceptable.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-17T22:18:09.680Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-17T22:18:09.680Z
Learning: Talawa Admin Phase 2A testing guideline: Allow vi.hoisted() + vi.mock() module-level mocks for shared dependencies; prefer afterEach(() => vi.clearAllMocks()) as default cleanup. Use afterEach(() => vi.restoreAllMocks()) only in suites that create vi.spyOn spies or patch real implementations. Avoid vi.resetAllMocks() globally. The generic “no module-level mocks” rule is updated to “no module-level vi.fn except vi.hoisted module mocks.”
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-13T18:07:48.621Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-13T18:07:48.621Z
Learning: In talawa-admin, Apollo Client pinned to 3.11.10 (not 3.14.0) to avoid deprecation warnings during test isolation work (PR #4565 Phase 2A-2B). Apollo 3.14.0's MockedProvider internally uses deprecated options causing console noise that interferes with debugging. Upgrade to 4.x blocked by dependency conflicts with apollo-upload-client and apollo/link-error. All addTypename props removed from 115+ test files for future compatibility. Will upgrade when dependencies support Apollo 4.x.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-03-11T17:45:54.621Z
Learnt from: PurnenduMIshra129th
Repo: PalisadoesFoundation/talawa-admin PR: 3814
File: src/components/UserPortal/OrganizationNavbar/OrganizationNavbar.spec.tsx:137-146
Timestamp: 2025-03-11T17:45:54.621Z
Learning: In OrganizationNavbar.spec.tsx, separate vi.mock implementations for react-router-dom are needed to avoid errors - one for useNavigate and another for useParams.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:45:57.175Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: In the talawa-admin project, the Advertisement component tests (3 files) use both ApolloProvider and MockedProvider together, though it's not a widespread pattern in the codebase. The maintainer has confirmed this approach is needed for these specific tests.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:45:57.175Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: Using both ApolloProvider and MockedProvider together in tests is an established pattern in this codebase, even though it's technically redundant from Apollo Client's best practices perspective.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-26T12:32:45.867Z
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 3400
File: src/screens/UserPortal/Organizations/Organizations.spec.tsx:19-19
Timestamp: 2025-01-26T12:32:45.867Z
Learning: In React test files, avoid using React hooks outside component scope (including in static objects like mock data). Instead, initialize hooks inside describe blocks or extract the needed functionality without using hooks.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-10-22T22:22:27.696Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/Requests/Requests.spec.tsx:0-0
Timestamp: 2025-10-22T22:22:27.696Z
Learning: In talawa-admin tests using react-infinite-scroll-component (e.g., src/screens/Requests/Requests.spec.tsx), jsdom scroll is flaky. Prefer a resilient approach: try querying the container via document.querySelector('[data-testid="infinite-scroll-component"]') and fall back to window scroll if missing. Strengthen assertions by checking for page-2 items (e.g., "User9 Test") to ensure fetchMore actually ran instead of relying only on row counts.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-02-20T13:35:01.218Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3712
File: src/components/EventCalender/Yearly/YearlyEventCalender.spec.tsx:113-127
Timestamp: 2025-02-20T13:35:01.218Z
Learning: In React component tests, when testing window resize event handling, it's acceptable to only verify that the event is properly triggered without assertions if the test's focus is specifically on event handling rather than responsive behavior. Testing the actual responsive rendering would be a separate test case.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-28T06:38:43.765Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2362
File: src/components/TagActions/TagActions.test.tsx:123-131
Timestamp: 2024-10-28T06:38:43.765Z
Learning: In `TagActions.test.tsx`, `link2` is the error link used to simulate errors, so the existing test cases sufficiently cover error handling.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-28T06:33:09.726Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2362
File: src/components/TagActions/TagActions.test.tsx:251-274
Timestamp: 2024-10-28T06:33:09.726Z
Learning: In `TagActions.test.tsx`, negative test cases for tag operations can be deferred and added later if necessary, according to the team's plan.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-08T16:13:41.996Z
Learnt from: Doraemon012
Repo: PalisadoesFoundation/talawa-admin PR: 1988
File: src/screens/MemberDetail/MemberDetail.test.tsx:170-195
Timestamp: 2024-10-08T16:13:41.996Z
Learning: In unit tests for this project, direct `click()` calls are acceptable; avoid suggesting replacing them with `userEvent.click()`.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:48:36.443Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/AddPeopleToTag/AddPeopleToTag.test.tsx:177-241
Timestamp: 2024-11-02T07:48:36.443Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.test.tsx`, prefer keeping test cases separate and more readable, even if it involves some duplication, instead of extracting common logic into helper functions.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T11:57:55.067Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/components/InfiniteScrollLoader/InfiniteScrollLoader.test.tsx:5-14
Timestamp: 2024-10-30T11:57:55.067Z
Learning: Currently, the developer considers the existing test coverage for the `InfiniteScrollLoader` component sufficient and prefers not to expand it at this time.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T12:54:20.857Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/OrganizationActionItems/testObject.mocks.ts:184-402
Timestamp: 2024-11-01T12:54:20.857Z
Learning: In `src/screens/OrganizationActionItems/testObject.mocks.ts`, test failures are not dependent on the `createdAt` fields; hardcoded dates in `createdAt` fields do not cause test failures in this file.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-25T19:31:37.405Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2355
File: src/screens/ManageTag/ManageTagMocks.ts:187-269
Timestamp: 2024-10-25T19:31:37.405Z
Learning: In `src/screens/ManageTag/ManageTagMocks.ts`, when mocking data for `USER_TAGS_ASSIGNED_MEMBERS` and `USER_TAGS_MEMBERS_TO_ASSIGN_TO`, it's acceptable for user IDs to overlap because the queries serve different purposes and the overlapping IDs can represent realistic scenarios in tests.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-06T05:15:51.829Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-06T05:15:51.829Z
Learning: In talawa-admin PR #4565, test sharding implementation achieved 2x speedup (8min → 4min) with conservative settings (maxConcurrency: 1, concurrent: false, maxThreads: 2 in CI) due to test isolation issues across 269 test files. These settings prevent OOM and race conditions. Higher speedup (3-4x) is achievable but requires systematic test isolation improvements. Apollo Client addTypename={false} deprecation warnings (142 files) are suppressed with TODO for follow-up fixes.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:41:55.660Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/Advertisements.spec.tsx:316-327
Timestamp: 2025-04-20T06:41:55.660Z
Learning: In the Talawa Admin project's test files, button click events may trigger asynchronous operations that require awaiting the act() call, even when using fireEvent.click() which is typically synchronous.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-07-11T20:14:07.922Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3988
File: cypress/pageObjects/AdminPortal/AdminDashboard.ts:4-5
Timestamp: 2025-07-11T20:14:07.922Z
Learning: In the talawa-admin project, mixing `data-cy` and `data-testid` attributes in Cypress selectors may be necessary due to technical constraints where UI library components have built-in `data-testid` attributes but don't support adding custom `data-cy` attributes.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-07-12T19:56:14.106Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3988
File: cypress/support/commands.ts:42-46
Timestamp: 2025-07-12T19:56:14.106Z
Learning: In the talawa-admin project, the toast notification component is a built-in component that doesn't support adding custom data-cy attributes. When testing toast messages in Cypress, use the `[role=alert]` selector combined with `contain.text` assertions to verify the expected message content, which works correctly even when multiple toasts are displayed simultaneously.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T15:46:05.784Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/components/AddPeopleToTag/AddPeopleToTag.tsx:78-104
Timestamp: 2024-10-30T15:46:05.784Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.tsx`, and similar components, the team prefers to keep the current implementation of the `updateQuery` logic in infinite scroll functionality consistent across all screens.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:39:51.950Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/screens/ManageTag/ManageTag.tsx:108-0
Timestamp: 2024-11-02T07:39:51.950Z
Learning: In `src/screens/ManageTag/ManageTag.tsx`, when `assignedMemberSearchFirstName` or `assignedMemberSearchLastName` are empty strings, the query in the `useQuery` for `USER_TAGS_ASSIGNED_MEMBERS` intentionally includes filters with empty strings to match all entries.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-12-02T04:20:11.745Z
Learnt from: bitbard3
Repo: PalisadoesFoundation/talawa-admin PR: 2588
File: src/components/ChangeLanguageDropdown/ChangeLanguageDropdown.spec.tsx:145-155
Timestamp: 2024-12-02T04:20:11.745Z
Learning: In PRs focused solely on refactoring test cases from Jest to Vitest, avoid suggesting optimizations or changes outside the migration scope.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T16:18:01.545Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/UserPortal/Volunteer/Actions/Actions.tsx:367-374
Timestamp: 2024-11-01T16:18:01.545Z
Learning: In the `src/screens/UserPortal/Volunteer/Actions/Actions.tsx` file, the search button intentionally includes `tabIndex={-1}`. This is acceptable for our application, and future reviews should not flag this as an accessibility concern.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-11T07:47:39.266Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2425
File: src/screens/MemberDetail/MemberDetail.test.tsx:100-100
Timestamp: 2024-11-11T07:47:39.266Z
Learning: In `src/screens/MemberDetail/MemberDetail.test.tsx`, using `await wait();` is acceptable to wait for the render to complete.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-15T05:39:30.480Z
Learnt from: arpit-chakraborty
Repo: PalisadoesFoundation/talawa-admin PR: 3158
File: src/screens/OrganizationTags/OrganizationTagsMocks.ts:384-524
Timestamp: 2025-01-15T05:39:30.480Z
Learning: In OrganizationTagsMocks.ts, MOCKS_NULL_END_CURSOR and MOCKS_NO_MORE_PAGES are designed to test UI handling of edge cases where pagination data is inconsistent (e.g., hasNextPage is true but endCursor is null, or next page returns undefined data).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
🧬 Code graph analysis (1)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (3)
src/GraphQl/Queries/Queries.ts (3)
EVENT_ATTENDEES(316-334)MEMBERS_LIST(808-820)EVENT_DETAILS(248-285)src/state/store.ts (1)
store(4-6)src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.tsx (1)
EventRegistrantsModal(65-209)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Generate and Validate Documentation
- GitHub Check: Check Python Code Style
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (6)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (6)
1-21: LGTM!Imports are well-organized with proper type imports for Apollo mocking. The GraphQL query/mutation imports align with what's needed for the test coverage.
23-89: LGTM!Both mock components are well-structured with proper
type="button"attributes, conditional rendering based onshow, and expose necessary props viadata-testidfor assertions. The InviteByEmailModal mock correctly handles the optionalonInvitesSentcallback.
91-98: LGTM!The
ApolloMocktype alias improves readability, anddefaultProps.handleCloseis correctly a no-op rather than a module-levelvi.fn(), which aligns with Phase 2A mock isolation guidelines.
242-259: LGTM!The
renderWithProvidershelper is clean and reduces boilerplate effectively. TheaddTypenameprop is correctly omitted per project conventions, and all necessary providers are properly nested.
261-441: LGTM!Test cases are well-structured with:
- Proper test isolation using per-test
vi.fn()forhandleClose- Clear descriptions matching what's being tested
- Appropriate use of
queryByLabelTextfor MUI Autocomplete (per learnings)- The duplicate
makeAttendeesEmptyMock()at line 406 correctly accounts for the refetch afterreloadMembers
443-514: LGTM!The invite modal tests properly validate the
eventIdandisRecurringprops for both non-recurring and recurring events. The "Unknown User" fallback test correctly exercises thegetOptionLabelfallback path usingfindByTextfor the async autocomplete options.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4865 +/- ##
===========================================
+ Coverage 94.26% 94.30% +0.03%
===========================================
Files 388 388
Lines 15055 15055
Branches 4525 4452 -73
===========================================
+ Hits 14192 14198 +6
+ Misses 828 822 -6
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx(4 hunks)
🧰 Additional context used
🧠 Learnings (42)
📓 Common learnings
Learnt from: Chaitanya1672
Repo: PalisadoesFoundation/talawa-admin PR: 2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-10-08T16:13:41.996Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-12T00:28:53.713Z
Learning: In talawa-admin PR #4565 continuation (PR #4664 planned), Phase 2A mock isolation strategy uses global vi.clearAllMocks() in afterEach (vitest.setup.ts) plus refactoring module-level vi.fn() into per-test beforeEach blocks across 6 parallelizable issues (2A.0 foundation, 2A.1-2A.4 directory-based fixes, 2A.5 validation). This approach addresses mock call history accumulation enabling maxConcurrency: 2 and 2.3-2.5x speedup. vi.restoreAllMocks() alternative considered for spy restoration during validation phase. Phase 2A (mocks) correctly separated from Phase 2B (DOM/Apollo).
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-11T11:51:09.236Z
Learning: In talawa-admin PR #4664 (continuation of PR #4565 sharding work), global mock cleanup was implemented via vi.clearAllMocks() in vitest.setup.ts afterEach, along with Apollo Client warning suppression (temporary, pending follow-up PR) and test suite refactoring to per-test StaticMockLink instances. This test isolation strategy addresses mock state leakage that forced maxConcurrency: 1 in PR #4565, enabling future parallel test execution improvements and 3-4x speedup potential.
Learnt from: palisadoes
Repo: PalisadoesFoundation/talawa-admin PR: 4718
File: src/components/EventManagement/Dashboard/EventDashboard.mocks.ts:83-114
Timestamp: 2025-11-21T12:42:24.884Z
Learning: In talawa-admin mock files (e.g., EventDashboard.mocks.ts), mock constant names must accurately reflect what they test. Mock names suggesting role-based logic (e.g., MOCKS_WITH_ADMIN_ROLE) are misleading when the component derives role from localStorage rather than mock data. Name mocks based on their distinguishing data features (e.g., MOCKS_WITH_SINGLE_ATTENDEE) or test context (e.g., MOCKS_FOR_ADMIN_STORAGE_TEST).
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts:0-0
Timestamp: 2025-10-22T22:00:53.943Z
Learning: In src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts (and similar mock files), avoid duplicating identical Apollo MockedProvider mocks for repeated query consumption. Prefer adding `maxUsageCount` to the existing mock or using `newData` for reusable responses to keep tests deterministic and reduce drift.
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 3400
File: src/screens/UserPortal/Organizations/Organizations.spec.tsx:19-19
Timestamp: 2025-01-26T12:32:45.867Z
Learning: In React test files, avoid using React hooks outside component scope (including in static objects like mock data). Instead, initialize hooks inside describe blocks or extract the needed functionality without using hooks.
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: In the talawa-admin project, the Advertisement component tests (3 files) use both ApolloProvider and MockedProvider together, though it's not a widespread pattern in the codebase. The maintainer has confirmed this approach is needed for these specific tests.
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-13T18:07:48.621Z
Learning: In talawa-admin, Apollo Client pinned to 3.11.10 (not 3.14.0) to avoid deprecation warnings during test isolation work (PR #4565 Phase 2A-2B). Apollo 3.14.0's MockedProvider internally uses deprecated options causing console noise that interferes with debugging. Upgrade to 4.x blocked by dependency conflicts with apollo-upload-client and apollo/link-error. All addTypename props removed from 115+ test files for future compatibility. Will upgrade when dependencies support Apollo 4.x.
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/AddPeopleToTag/AddPeopleToTag.test.tsx:177-241
Timestamp: 2024-11-02T07:48:36.443Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.test.tsx`, prefer keeping test cases separate and more readable, even if it involves some duplication, instead of extracting common logic into helper functions.
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 2718
File: src/screens/UserPortal/Settings/Settings.spec.tsx:0-0
Timestamp: 2024-12-22T17:58:17.818Z
Learning: The matchMedia mock implementation in `Settings.spec.tsx` no longer includes the deprecated addListener and removeListener methods, opting solely for addEventListener and removeEventListener.
📚 Learning: 2025-11-21T12:42:24.884Z
Learnt from: palisadoes
Repo: PalisadoesFoundation/talawa-admin PR: 4718
File: src/components/EventManagement/Dashboard/EventDashboard.mocks.ts:83-114
Timestamp: 2025-11-21T12:42:24.884Z
Learning: In talawa-admin mock files (e.g., EventDashboard.mocks.ts), mock constant names must accurately reflect what they test. Mock names suggesting role-based logic (e.g., MOCKS_WITH_ADMIN_ROLE) are misleading when the component derives role from localStorage rather than mock data. Name mocks based on their distinguishing data features (e.g., MOCKS_WITH_SINGLE_ATTENDEE) or test context (e.g., MOCKS_FOR_ADMIN_STORAGE_TEST).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-08T16:13:41.996Z
Learnt from: Chaitanya1672
Repo: PalisadoesFoundation/talawa-admin PR: 2049
File: src/screens/OrganizationActionItems/ActionItemUpdateModal.tsx:112-138
Timestamp: 2024-10-08T16:13:41.996Z
Learning: The `istanbul ignore next` comments in the `ActionItemUpdateModal.tsx` file were added as part of a commit that introduced tests for the `ActionItemUpdateModal` component. Removing these comments and writing tests to cover the previously ignored lines is recommended to ensure code integrity and improve test coverage.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-27T11:40:30.717Z
Learnt from: rawadhossain
Repo: PalisadoesFoundation/talawa-admin PR: 4865
File: src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx:261-280
Timestamp: 2025-11-27T11:40:30.717Z
Learning: In Talawa Admin tests (e.g., src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx), react-bootstrap Modal header close buttons don't support custom test IDs, so using getAllByRole('button', { name: /close/i })[0] to select the modal's primary close action is acceptable and stable, as the Modal component consistently exposes "Close" as the accessible label.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-12-22T17:58:17.818Z
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 2718
File: src/screens/UserPortal/Settings/Settings.spec.tsx:0-0
Timestamp: 2024-12-22T17:58:17.818Z
Learning: The matchMedia mock implementation in `Settings.spec.tsx` no longer includes the deprecated addListener and removeListener methods, opting solely for addEventListener and removeEventListener.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-12T00:28:53.713Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-12T00:28:53.713Z
Learning: In talawa-admin PR #4565 continuation (PR #4664 planned), Phase 2A mock isolation strategy uses global vi.clearAllMocks() in afterEach (vitest.setup.ts) plus refactoring module-level vi.fn() into per-test beforeEach blocks across 6 parallelizable issues (2A.0 foundation, 2A.1-2A.4 directory-based fixes, 2A.5 validation). This approach addresses mock call history accumulation enabling maxConcurrency: 2 and 2.3-2.5x speedup. vi.restoreAllMocks() alternative considered for spy restoration during validation phase. Phase 2A (mocks) correctly separated from Phase 2B (DOM/Apollo).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T12:01:40.366Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/screens/ManageTag/ManageTagMockComponents/MockAddPeopleToTag.tsx:1-28
Timestamp: 2024-10-30T12:01:40.366Z
Learning: In the `MockAddPeopleToTag` component in `src/screens/ManageTag/ManageTagMockComponents/MockAddPeopleToTag.tsx`, it's acceptable to implement only the necessary props from `InterfaceAddPeopleToTagProps` and omit others like `refetchAssignedMembersData`, `t`, and `tCommon` that are tested separately.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-10-22T22:00:53.943Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts:0-0
Timestamp: 2025-10-22T22:00:53.943Z
Learning: In src/screens/OrganizationDashboard/OrganizationDashboardMocks.ts (and similar mock files), avoid duplicating identical Apollo MockedProvider mocks for repeated query consumption. Prefer adding `maxUsageCount` to the existing mock or using `newData` for reusable responses to keep tests deterministic and reduce drift.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-11T11:51:09.236Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-11T11:51:09.236Z
Learning: In talawa-admin PR #4664 (continuation of PR #4565 sharding work), global mock cleanup was implemented via vi.clearAllMocks() in vitest.setup.ts afterEach, along with Apollo Client warning suppression (temporary, pending follow-up PR) and test suite refactoring to per-test StaticMockLink instances. This test isolation strategy addresses mock state leakage that forced maxConcurrency: 1 in PR #4565, enabling future parallel test execution improvements and 3-4x speedup potential.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-27T11:41:54.834Z
Learnt from: rawadhossain
Repo: PalisadoesFoundation/talawa-admin PR: 4865
File: src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx:302-328
Timestamp: 2025-11-27T11:41:54.834Z
Learning: In Talawa Admin tests (e.g., src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx), using queryByLabelText with an HTMLElement cast for MUI Autocomplete inputs is acceptable because the Autocomplete input can mount asynchronously and isn't always available for strict getBy* queries at initial render. This pattern is stable for MUI Autocomplete components.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-12-02T04:20:11.745Z
Learnt from: bitbard3
Repo: PalisadoesFoundation/talawa-admin PR: 2588
File: src/components/ChangeLanguageDropdown/ChangeLanguageDropdown.spec.tsx:145-155
Timestamp: 2024-12-02T04:20:11.745Z
Learning: In PRs focused solely on refactoring test cases from Jest to Vitest, avoid suggesting optimizations or changes outside the migration scope.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-02-09T06:22:23.028Z
Learnt from: adithyanotfound
Repo: PalisadoesFoundation/talawa-admin PR: 3569
File: src/screens/UserPortal/Settings/Settings.spec.tsx:314-316
Timestamp: 2025-02-09T06:22:23.028Z
Learning: In the Settings component's tests, `fireEvent.change` should be used instead of `userEvent.type` for the address input field, as `userEvent` doesn't work correctly in this case.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-08-13T06:52:48.055Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 4040
File: cypress/pageObjects/AdminPortal/PeoplePage.ts:30-34
Timestamp: 2025-08-13T06:52:48.055Z
Learning: In the talawa-admin project's Cypress tests, specifically in cypress/pageObjects/AdminPortal/PeoplePage.ts, the element '[data-testid="existingUser"]' is a toggle control that requires .trigger('click') instead of .click() because it's not a standard button but a custom UI component that needs direct event triggering.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:31:50.788Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/TagActions/TagActions.tsx:216-0
Timestamp: 2024-11-02T07:31:50.788Z
Learning: In `src/components/TagActions/TagActions.tsx`, the submit button should not be disabled when no tags are selected, as per the design preference.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T13:26:46.088Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/UserPortal/Volunteer/Actions/Actions.mocks.ts:3-119
Timestamp: 2024-11-01T13:26:46.088Z
Learning: In `src/screens/UserPortal/Volunteer/Actions/Actions.mocks.ts`, the `dueDate` fields in mock data do not determine any test process status, so using future dates is acceptable.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-17T22:18:09.680Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-17T22:18:09.680Z
Learning: Talawa Admin Phase 2A testing guideline: Allow vi.hoisted() + vi.mock() module-level mocks for shared dependencies; prefer afterEach(() => vi.clearAllMocks()) as default cleanup. Use afterEach(() => vi.restoreAllMocks()) only in suites that create vi.spyOn spies or patch real implementations. Avoid vi.resetAllMocks() globally. The generic “no module-level mocks” rule is updated to “no module-level vi.fn except vi.hoisted module mocks.”
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-13T18:07:48.621Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-13T18:07:48.621Z
Learning: In talawa-admin, Apollo Client pinned to 3.11.10 (not 3.14.0) to avoid deprecation warnings during test isolation work (PR #4565 Phase 2A-2B). Apollo 3.14.0's MockedProvider internally uses deprecated options causing console noise that interferes with debugging. Upgrade to 4.x blocked by dependency conflicts with apollo-upload-client and apollo/link-error. All addTypename props removed from 115+ test files for future compatibility. Will upgrade when dependencies support Apollo 4.x.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-03-11T17:45:54.621Z
Learnt from: PurnenduMIshra129th
Repo: PalisadoesFoundation/talawa-admin PR: 3814
File: src/components/UserPortal/OrganizationNavbar/OrganizationNavbar.spec.tsx:137-146
Timestamp: 2025-03-11T17:45:54.621Z
Learning: In OrganizationNavbar.spec.tsx, separate vi.mock implementations for react-router-dom are needed to avoid errors - one for useNavigate and another for useParams.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:45:57.175Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: In the talawa-admin project, the Advertisement component tests (3 files) use both ApolloProvider and MockedProvider together, though it's not a widespread pattern in the codebase. The maintainer has confirmed this approach is needed for these specific tests.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:45:57.175Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.spec.tsx:403-421
Timestamp: 2025-04-20T06:45:57.175Z
Learning: Using both ApolloProvider and MockedProvider together in tests is an established pattern in this codebase, even though it's technically redundant from Apollo Client's best practices perspective.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-26T12:32:45.867Z
Learnt from: IITI-tushar
Repo: PalisadoesFoundation/talawa-admin PR: 3400
File: src/screens/UserPortal/Organizations/Organizations.spec.tsx:19-19
Timestamp: 2025-01-26T12:32:45.867Z
Learning: In React test files, avoid using React hooks outside component scope (including in static objects like mock data). Instead, initialize hooks inside describe blocks or extract the needed functionality without using hooks.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-10-22T22:22:27.696Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4524
File: src/screens/Requests/Requests.spec.tsx:0-0
Timestamp: 2025-10-22T22:22:27.696Z
Learning: In talawa-admin tests using react-infinite-scroll-component (e.g., src/screens/Requests/Requests.spec.tsx), jsdom scroll is flaky. Prefer a resilient approach: try querying the container via document.querySelector('[data-testid="infinite-scroll-component"]') and fall back to window scroll if missing. Strengthen assertions by checking for page-2 items (e.g., "User9 Test") to ensure fetchMore actually ran instead of relying only on row counts.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-02-20T13:35:01.218Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3712
File: src/components/EventCalender/Yearly/YearlyEventCalender.spec.tsx:113-127
Timestamp: 2025-02-20T13:35:01.218Z
Learning: In React component tests, when testing window resize event handling, it's acceptable to only verify that the event is properly triggered without assertions if the test's focus is specifically on event handling rather than responsive behavior. Testing the actual responsive rendering would be a separate test case.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-01T16:34:10.347Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-01T16:34:10.347Z
Learning: In talawa-admin parallel test sharding (PR #4565), Bootstrap modals render via portals to document.body, causing screen.getByRole('dialog') to find dialogs from ALL concurrent test shards. Solution: use unique data-testid per modal instance and query within that scope using within() helper, or use findAllByTestId and take last element (less robust, timing-dependent).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-28T06:38:43.765Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2362
File: src/components/TagActions/TagActions.test.tsx:123-131
Timestamp: 2024-10-28T06:38:43.765Z
Learning: In `TagActions.test.tsx`, `link2` is the error link used to simulate errors, so the existing test cases sufficiently cover error handling.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-28T06:33:09.726Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2362
File: src/components/TagActions/TagActions.test.tsx:251-274
Timestamp: 2024-10-28T06:33:09.726Z
Learning: In `TagActions.test.tsx`, negative test cases for tag operations can be deferred and added later if necessary, according to the team's plan.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-08T16:13:41.996Z
Learnt from: Doraemon012
Repo: PalisadoesFoundation/talawa-admin PR: 1988
File: src/screens/MemberDetail/MemberDetail.test.tsx:170-195
Timestamp: 2024-10-08T16:13:41.996Z
Learning: In unit tests for this project, direct `click()` calls are acceptable; avoid suggesting replacing them with `userEvent.click()`.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:48:36.443Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/components/AddPeopleToTag/AddPeopleToTag.test.tsx:177-241
Timestamp: 2024-11-02T07:48:36.443Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.test.tsx`, prefer keeping test cases separate and more readable, even if it involves some duplication, instead of extracting common logic into helper functions.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T11:57:55.067Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/components/InfiniteScrollLoader/InfiniteScrollLoader.test.tsx:5-14
Timestamp: 2024-10-30T11:57:55.067Z
Learning: Currently, the developer considers the existing test coverage for the `InfiniteScrollLoader` component sufficient and prefers not to expand it at this time.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T12:54:20.857Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/OrganizationActionItems/testObject.mocks.ts:184-402
Timestamp: 2024-11-01T12:54:20.857Z
Learning: In `src/screens/OrganizationActionItems/testObject.mocks.ts`, test failures are not dependent on the `createdAt` fields; hardcoded dates in `createdAt` fields do not cause test failures in this file.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-25T19:31:37.405Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2355
File: src/screens/ManageTag/ManageTagMocks.ts:187-269
Timestamp: 2024-10-25T19:31:37.405Z
Learning: In `src/screens/ManageTag/ManageTagMocks.ts`, when mocking data for `USER_TAGS_ASSIGNED_MEMBERS` and `USER_TAGS_MEMBERS_TO_ASSIGN_TO`, it's acceptable for user IDs to overlap because the queries serve different purposes and the overlapping IDs can represent realistic scenarios in tests.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-11-06T05:15:51.829Z
Learnt from: Ansingh0305
Repo: PalisadoesFoundation/talawa-admin PR: 0
File: :0-0
Timestamp: 2025-11-06T05:15:51.829Z
Learning: In talawa-admin PR #4565, test sharding implementation achieved 2x speedup (8min → 4min) with conservative settings (maxConcurrency: 1, concurrent: false, maxThreads: 2 in CI) due to test isolation issues across 269 test files. These settings prevent OOM and race conditions. Higher speedup (3-4x) is achievable but requires systematic test isolation improvements. Apollo Client addTypename={false} deprecation warnings (142 files) are suppressed with TODO for follow-up fixes.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-04-20T06:41:55.660Z
Learnt from: bandhan-majumder
Repo: PalisadoesFoundation/talawa-admin PR: 3926
File: src/components/Advertisements/Advertisements.spec.tsx:316-327
Timestamp: 2025-04-20T06:41:55.660Z
Learning: In the Talawa Admin project's test files, button click events may trigger asynchronous operations that require awaiting the act() call, even when using fireEvent.click() which is typically synchronous.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-07-11T20:14:07.922Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3988
File: cypress/pageObjects/AdminPortal/AdminDashboard.ts:4-5
Timestamp: 2025-07-11T20:14:07.922Z
Learning: In the talawa-admin project, mixing `data-cy` and `data-testid` attributes in Cypress selectors may be necessary due to technical constraints where UI library components have built-in `data-testid` attributes but don't support adding custom `data-cy` attributes.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-07-12T19:56:14.106Z
Learnt from: syedali237
Repo: PalisadoesFoundation/talawa-admin PR: 3988
File: cypress/support/commands.ts:42-46
Timestamp: 2025-07-12T19:56:14.106Z
Learning: In the talawa-admin project, the toast notification component is a built-in component that doesn't support adding custom data-cy attributes. When testing toast messages in Cypress, use the `[role=alert]` selector combined with `contain.text` assertions to verify the expected message content, which works correctly even when multiple toasts are displayed simultaneously.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-10-30T15:46:05.784Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2387
File: src/components/AddPeopleToTag/AddPeopleToTag.tsx:78-104
Timestamp: 2024-10-30T15:46:05.784Z
Learning: In `src/components/AddPeopleToTag/AddPeopleToTag.tsx`, and similar components, the team prefers to keep the current implementation of the `updateQuery` logic in infinite scroll functionality consistent across all screens.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-02T07:39:51.950Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2398
File: src/screens/ManageTag/ManageTag.tsx:108-0
Timestamp: 2024-11-02T07:39:51.950Z
Learning: In `src/screens/ManageTag/ManageTag.tsx`, when `assignedMemberSearchFirstName` or `assignedMemberSearchLastName` are empty strings, the query in the `useQuery` for `USER_TAGS_ASSIGNED_MEMBERS` intentionally includes filters with empty strings to match all entries.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-01T16:18:01.545Z
Learnt from: GlenDsza
Repo: PalisadoesFoundation/talawa-admin PR: 2397
File: src/screens/UserPortal/Volunteer/Actions/Actions.tsx:367-374
Timestamp: 2024-11-01T16:18:01.545Z
Learning: In the `src/screens/UserPortal/Volunteer/Actions/Actions.tsx` file, the search button intentionally includes `tabIndex={-1}`. This is acceptable for our application, and future reviews should not flag this as an accessibility concern.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-23T14:03:01.877Z
Learnt from: varshith257
Repo: PalisadoesFoundation/talawa-admin PR: 3392
File: schema.graphql:485-487
Timestamp: 2025-01-23T14:03:01.877Z
Learning: Use EmailAddress scalar type instead of String for email fields in GraphQL schema to ensure proper email validation.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-08-11T07:35:33.735Z
Learnt from: Jashan32
Repo: PalisadoesFoundation/talawa-admin PR: 4073
File: src/components/Venues/VenueCardMocks.ts:4-10
Timestamp: 2025-08-11T07:35:33.735Z
Learning: In the Talawa Admin project, the capacity field is included in venue mock data and UI components (VenueCard.tsx, VenueCardMocks.ts) but is not actually returned by the VENUE_LIST query from the backend. This creates a temporary mismatch where the UI expects capacity but the API doesn't provide it. The field will be added back once the backend API is updated.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2024-11-11T07:47:39.266Z
Learnt from: meetulr
Repo: PalisadoesFoundation/talawa-admin PR: 2425
File: src/screens/MemberDetail/MemberDetail.test.tsx:100-100
Timestamp: 2024-11-11T07:47:39.266Z
Learning: In `src/screens/MemberDetail/MemberDetail.test.tsx`, using `await wait();` is acceptable to wait for the render to complete.
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
📚 Learning: 2025-01-15T05:39:30.480Z
Learnt from: arpit-chakraborty
Repo: PalisadoesFoundation/talawa-admin PR: 3158
File: src/screens/OrganizationTags/OrganizationTagsMocks.ts:384-524
Timestamp: 2025-01-15T05:39:30.480Z
Learning: In OrganizationTagsMocks.ts, MOCKS_NULL_END_CURSOR and MOCKS_NO_MORE_PAGES are designed to test UI handling of edge cases where pagination data is inconsistent (e.g., hasNextPage is true but endCursor is null, or next page returns undefined data).
Applied to files:
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Check Python Code Style
- GitHub Check: Generate and Validate Documentation
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (7)
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.spec.tsx (7)
1-22: LGTM!Clean import organization with proper type import for
MockedResponseand explicit GraphQL query/mutation imports.
23-52: LGTM!AddOnSpotAttendee mock correctly includes
type="button"on both buttons and exposes the necessary callbacks for testing modal interactions.
54-89: LGTM!InviteByEmailModal mock properly exposes
eventIdandisRecurringfor test assertions, includestype="button"on buttons, and conditionally renders the Send Invites button based ononInvitesSentpresence.
91-98: LGTM!Good pattern:
defaultProps.handleCloseis a no-op function rather than a module-levelvi.fn(), aligning with Phase 2A mock isolation strategy. Tests that need to assert calls (like line 276) correctly create their own spy.
100-240: LGTM!Well-structured mock factories with accurate naming that reflects data characteristics. Schema alignment is correct:
emailAddressfield used consistently (notrecurrenceRuleis an object withidproperty matching the query shape- Separate mutation mocks for recurring (
recurringEventInstanceId) vs non-recurring (eventId) events
242-259: LGTM!Clean test wrapper helper with proper provider nesting. Correctly omits
addTypename={false}to align with Apollo upgrade preparation.
261-514: Comprehensive test coverage achieved.The test suite effectively covers:
- Modal rendering and basic elements
- Close button behavior with proper spy assertion
- Warning state when no member selected
- Add registrant success/error paths for both non-recurring and recurring events (exercising
isRecurringbranch andaddVariablesconstruction)- InviteByEmailModal open/close flow with
eventIdandisRecurringverificationonInvitesSentcallback pathway (coverage-only, as acknowledged)getOptionLabelfallback to "Unknown User" for empty member names- AddOnSpotAttendee modal interactions including
reloadMemberscallbackThis aligns well with the PR objective of achieving 100% coverage for the target file.
palisadoes
added
the
ignore-sensitive-files-pr
Contributor
|
@coderabbitai full review and reevaluate all resolved items. If the PR requires any changes, even trivial ones, then give your review a “requested changes” status. If no changes are required then give the PR an “approved” status. Please ensure code rabbit approves your changes, even the trivial ones |
Contributor
🧩 Analysis chain🏁 Script executed: Length of output: 167237 🏁 Script executed: Length of output: 33297 🏁 Script executed: Length of output: 6870 🏁 Script executed: Length of output: 14198 🏁 Script executed: Length of output: 0 🏁 Script executed: Length of output: 674 🏁 Script executed: Length of output: 3 🏁 Script executed: Length of output: 3 🏁 Script executed: Length of output: 0 🏁 Script executed: Length of output: 429 🏁 Script executed: Length of output: 3517 @palisadoes, I have completed a comprehensive full review and re-evaluated all resolved items. Here is my assessment: ✅ PR Status: APPROVED - No Changes RequiredCoverage AchievementThe PR successfully achieves 100% test coverage for Core Functionality:
Critical Branching Logic:
Modal Interactions:
Edge Cases:
Code Quality
CI Status
Pre-commit Hook FixThe Conclusion: This PR fully satisfies all acceptance criteria from issue #4849. The test coverage is comprehensive, valid, and achieves 100% for the target file. All code follows project conventions and quality standards. 🧠 Learnings used✅ Actions performedComments resolved and changes approved. |
palisadoes
approved these changes
Nov 27, 2025
Contributor
|
@coderabbitai why is our "Check CodeRabbit Approval" workflow in the |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1791 🏁 Script executed: Length of output: 0 🏁 Script executed: Length of output: 164 🏁 Script executed: Length of output: 1189 🏁 Script executed: Length of output: 7331 🏁 Script executed: Length of output: 149041 @palisadoes, I've identified the issue. The workflow is failing because it's checking the latest review by timestamp, and my most recent review is a Here's the timeline:
The Problem: The Fix: // Filter for decision-making reviews only (exclude COMMENTED)
const codeRabbitReviews = reviews.filter(review =>
(review.user.login.toLowerCase().includes('coderabbit') ||
review.user.login.toLowerCase().includes('coderabbitai')) &&
review.state !== 'COMMENTED'
);This ensures that only Would you like me to create an issue to track this workflow fix? 🧠 Learnings used |
Author
|
@palisadoes I think the failed CI issue has been fixed. Is there anything I need to do to pass the tests or get merged? |
palisadoes
merged commit 7c422a5
into
PalisadoesFoundation:develop
45 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Improved coverage for
src/components/EventRegistrantsModal/Modal/EventRegistrantsModal.tsxIssue Number:
Fixes #4849
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Brief summary of newly added coverage:
isRecurringlogic andEVENT_DETAILSbranchingaddVariablesgetOptionLabelfallback (“Unknown User”) branch coveredNote:
The pre-commit hook was failing because
check_pom.jsused the old glob default export and sync API, which were removed in glob v13. I updated the script to use the correctglobSyncimport so it works properly with the current library version.Does this PR introduce a breaking change?
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Summary by CodeRabbit
Tests
Style
✏️ Tip: You can customize this high-level summary in your review settings.