Fix ESLint Errors During Install #4703
Conversation
|
No significant changes currently retry |
WalkthroughThe PR updates the ESLint configuration and dependencies to replace the deprecated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4703 +/- ##
===========================================
+ Coverage 92.77% 92.78% +0.01%
===========================================
Files 134 398 +264
Lines 3238 15049 +11811
Branches 904 4492 +3588
===========================================
+ Hits 3004 13963 +10959
- Misses 225 1043 +818
- Partials 9 43 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
242b24f
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Bugfix - resolves ESLint dependency warnings that occurred during
npm install.Issue Number:
Fixes #4681
If relevant, did you update the documentation?
Not applicable.
Summary
eslint-plugin-vitest@0.5.4depended on@typescript-eslint/utils@7.x, which requireseslint@^8, conflicting with the project’s ESLint 9.x setup.eslint-plugin-vitestand replacing it with the officially maintained@vitest/eslint-plugin, updating the config accordingly so installs complete without warnings.Does this PR introduce a breaking change?
No
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Summary by CodeRabbit