Skip to content

Fix ESLint Errors During Install #4703

Merged
palisadoes merged 1 commit into
PalisadoesFoundation:developfrom
rawadhossain:fix/eslint-install-warn-errors
Nov 13, 2025
Merged

Fix ESLint Errors During Install #4703
palisadoes merged 1 commit into
PalisadoesFoundation:developfrom
rawadhossain:fix/eslint-install-warn-errors

Conversation

@rawadhossain
Copy link
Copy Markdown

@rawadhossain rawadhossain commented Nov 13, 2025

What kind of change does this PR introduce?

Bugfix - resolves ESLint dependency warnings that occurred during npm install.

Issue Number:

Fixes #4681

If relevant, did you update the documentation?
Not applicable.

Summary

  • ESLint warnings occurred because the deprecated eslint-plugin-vitest@0.5.4 depended on @typescript-eslint/utils@7.x, which requires eslint@^8, conflicting with the project’s ESLint 9.x setup.
  • Since Talawa Admin uses ESLint 9.x and TypeScript-ESLint 8.x, the old plugin produced warnings.
  • Issue was resolved by removing eslint-plugin-vitest and replacing it with the officially maintained @vitest/eslint-plugin, updating the config accordingly so installs complete without warnings.

Does this PR introduce a breaking change?
No

Checklist

CodeRabbit AI Review

  • I have reviewed and addressed all critical issues flagged by CodeRabbit AI
  • I have implemented or provided justification for each non-critical suggestion
  • I have documented my reasoning in the PR comments where CodeRabbit AI suggestions were not implemented

Test Coverage

  • I have written tests for all new changes/features
  • I have verified that test coverage meets or exceeds 95%
  • I have run the test suite locally and all tests pass

Other information

Have you read the contributing guide?

Summary by CodeRabbit

  • Chores
    • Updated development linting configuration to improve TypeScript file detection across project directories.
    • Upgraded linting dependencies to enhance code quality analysis.

@keploy
Copy link
Copy Markdown

keploy Bot commented Nov 13, 2025

No significant changes currently retry

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 13, 2025

Walkthrough

The PR updates the ESLint configuration and dependencies to replace the deprecated eslint-plugin-vitest package with @vitest/eslint-plugin@^1.4.2. Additionally, the TypeScript file matching pattern is expanded to include subdirectories using glob patterns.

Changes

Cohort / File(s) Summary
ESLint Configuration Update
eslint.config.js
Replaces ESLint plugin import from eslint-plugin-vitest to @vitest/eslint-plugin; updates TypeScript file pattern matching from ['*.ts', '*.tsx'] to ['**/*.ts', '**/*.tsx'] to include subdirectories
Dependency Management
package.json
Adds @vitest/eslint-plugin@^1.4.2 as a devDependency; removes eslint-plugin-vitest devDependency

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The PR description covers the required template sections: change type (bugfix), issue number (#4681), summary of root cause and solution, and confirmation of no breaking changes.
Linked Issues check ✅ Passed The code changes directly address issue #4681 by replacing the deprecated eslint-plugin-vitest with @vitest/eslint-plugin and updating the ESLint config, eliminating the peer dependency conflict.
Out of Scope Changes check ✅ Passed All changes are scoped to resolving the ESLint dependency issue: only eslint.config.js and package.json files modified with minimal, targeted updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Fix ESLint Errors During Install' accurately describes the main change: resolving ESLint dependency conflicts that caused install-time warnings.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@rawadhossain rawadhossain changed the title Fix ESLint Errors During Install (Issue #4681) Fix ESLint Errors During Install Nov 13, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (655b6b3) to head (3f91d84).
⚠️ Report is 837 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4703      +/-   ##
===========================================
+ Coverage    92.77%   92.78%   +0.01%     
===========================================
  Files          134      398     +264     
  Lines         3238    15049   +11811     
  Branches       904     4492    +3588     
===========================================
+ Hits          3004    13963   +10959     
- Misses         225     1043     +818     
- Partials         9       43      +34     
Flag Coverage Δ
vitest 92.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@palisadoes palisadoes added the ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files label Nov 13, 2025
@palisadoes palisadoes merged commit 242b24f into PalisadoesFoundation:develop Nov 13, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants