-
-
Notifications
You must be signed in to change notification settings - Fork 953
Update dependabot config to sync lockfile #3984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependabot config to sync lockfile #3984
Conversation
WalkthroughThe package manager specification in Changes
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3984 +/- ##
===========================================
- Coverage 86.46% 86.45% -0.02%
===========================================
Files 357 357
Lines 9083 9083
Branches 1916 1916
===========================================
- Hits 7854 7853 -1
Misses 852 852
- Partials 377 378 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varshith257
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think update-lockfile field does not exist in the Dependabot configuration reference. Look at this
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference?utm_source=perplexity#versioning-strategy--
Here is related discussion and solution, refer here - dependabot/dependabot-core#6346 (comment)
|
@varshith257 Yes, you’re right that was a mistake on my part, update-lockfile isn’t a supported field in Dependabot. I’ve reviewed the documentation and the discussion, and I’m making the appropriate changes now. |
|
@hkumar1729 The fix in the issue us discussed around packageManager in package.json. Maybe you need to get there to fix this issue |
varshith257
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkumar1729 Currently we have packageManager as yarn in package.json check if yarn.lock is syncing with it(I think it is in sync with package.json.
Maybe you can update to use two package managers. Check if it is supported?
|
@varshith257 If this is required, I’d like to look into it further and get back to you if I find anything.
|
|
@varshith257 Yes sir, packageManager is responsible for this. I updated it to the current version of npm now the pr raised by dependabot also includes package-lock.json. Check this pr |
|
@hkumar1729 Looks good! Apply same changes here and will merge PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/dependabot.yaml(1 hunks)package.json(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/dependabot.yaml
[error] 18-18: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Performs linting, formatting, type-checking, checking for different source and target branch
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (1)
package.json (1)
200-200: Confirm lockfile synchronization by running npm ci
ThepackageManagerfield is now[email protected], which Dependabot uses to updatepackage-lock.json. Please runnpm cilocally to verify that the lockfile is present and in sync withpackage.json.
95892ae
into
PalisadoesFoundation:develop
|
@varshith257 It looks like dependabot is still trying to update |

What kind of change does this PR introduce?
Updates Dependabot config to keep
package-lock.jsonin sync withpackage.json.Issue Number:
#3983
Snapshots/Videos:
NA
Reference:
Run
npm help cifor info.If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
No
Summary by CodeRabbit