move advbox to paddle model directory #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
Jan 16, 2018
fluid/adversarial/advbox/__init__.py
Outdated
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
Contributor
There was a problem hiding this comment.
@lcy-seso As all files in models repo don't have the license now, should we remove the license from this PR?
luotao1
reviewed
Jan 16, 2018
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
You should remove this file: fluid/adversarial/advbox/.init.py.swp
Contributor
|
Maybe you can improve the README.md in next PRs, since current README.md is so short, and lack of background. |
Author
|
OK. I will improve the README.md in next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix PaddlePaddle/Paddle#7542