Skip to content

Comments

init test framework#541

Closed
Superjomn wants to merge 2 commits intoPaddlePaddle:developfrom
Superjomn:design/test-framework
Closed

init test framework#541
Superjomn wants to merge 2 commits intoPaddlePaddle:developfrom
Superjomn:design/test-framework

Conversation

@Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Dec 13, 2017

fixes: #521

Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change the grammar?

@dzhwinter
Copy link
Contributor

Please dismiss the previous Approve, it's a mistake click.

Copy link

@kavyasrinet kavyasrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bunch of rephrasing comments, maybe once the other reviewers approve this PR, we can merge this and I can create a new PR with the suggested rephrasing and you folks can review it. I was trying to point them out here, but there are quite a few of them, so I stopped at two.

@@ -0,0 +1,81 @@
# Models continuous integration

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Models continuous integration" => "Continuous integration for models"

This framework aims to add continuous integration to formal models based on PaddlePaddle.

## Background
Currently, there are two official repositories that provide open source models based on PaddlePaddle:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"based on" => "using"

Copy link
Contributor

@wanghaoshuang wanghaoshuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a supplement:
We should make standards for feeding arguments to model trainning.
e.g. :save_dir_path of 'generate_chinese_poetry' is different with model_save_dir of 'text_classification'.

Furthermore, building models bank as a python module may be helpful for implementing test framework conveniently. After pip install paddle-models-versionxxx we can use models as below:

import paddle.models
model = models.text_classification()
arguments = {'batch_size': 128, 'train_passes':500 ...}
model.setArgs(arguments)
model.train()

@Superjomn Superjomn closed this May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

models 效果和精度持续测试机制及框架

4 participants