Skip to content

[Fix]fix loraga amp#9699

Merged
wawltor merged 1 commit into
PaddlePaddle:developfrom
greycooker:fix_loraga_amp
Dec 26, 2024
Merged

[Fix]fix loraga amp#9699
wawltor merged 1 commit into
PaddlePaddle:developfrom
greycooker:fix_loraga_amp

Conversation

@greycooker
Copy link
Copy Markdown
Contributor

PR types

Bug fixes

PR changes

APIs

Description

复用Trainer training_step,避免前向过程因为autocast数据类型报错

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Dec 26, 2024

Thanks for your contribution!

Copy link
Copy Markdown
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.00%. Comparing base (40fa402) to head (a1987bb).
Report is 264 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/peft/lora/loraga_utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9699      +/-   ##
===========================================
+ Coverage    52.06%   53.00%   +0.94%     
===========================================
  Files          727      718       -9     
  Lines       118173   112370    -5803     
===========================================
- Hits         61522    59564    -1958     
+ Misses       56651    52806    -3845     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit d007615 into PaddlePaddle:develop Dec 26, 2024
@greycooker greycooker deleted the fix_loraga_amp branch January 2, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants