Skip to content

[ChatTemplate] Fix chat template for Yuan when answer is contained within question. #9485

Merged
DrownFish19 merged 2 commits into
PaddlePaddle:developfrom
lvdongyi:fix-20241123-chat-template-for-yuan
Nov 26, 2024
Merged

[ChatTemplate] Fix chat template for Yuan when answer is contained within question. #9485
DrownFish19 merged 2 commits into
PaddlePaddle:developfrom
lvdongyi:fix-20241123-chat-template-for-yuan

Conversation

@lvdongyi
Copy link
Copy Markdown
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fix chat template for Yuan when answer is contained within question.
This PR is related to #9444

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Nov 23, 2024

Thanks for your contribution!

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.01%. Comparing base (1ba3bef) to head (9be04bf).
Report is 7 commits behind head on develop.

Current head 9be04bf differs from pull request most recent head b6c9ac9

Please upload reports for the commit b6c9ac9 to get more accurate results.

Files with missing lines Patch % Lines
paddlenlp/transformers/yuan/tokenizer.py 90.69% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9485      +/-   ##
===========================================
- Coverage    53.08%   53.01%   -0.08%     
===========================================
  Files          687      685       -2     
  Lines       109472   108944     -528     
===========================================
- Hits         58114    57756     -358     
+ Misses       51358    51188     -170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DrownFish19 DrownFish19 merged commit 131888e into PaddlePaddle:develop Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants