Skip to content

[Trainer] fix save_model#9287

Merged
wawltor merged 9 commits into
PaddlePaddle:release/3.0-beta2from
DesmonDay:origin_release_3.0-beta2
Oct 17, 2024
Merged

[Trainer] fix save_model#9287
wawltor merged 9 commits into
PaddlePaddle:release/3.0-beta2from
DesmonDay:origin_release_3.0-beta2

Conversation

@DesmonDay
Copy link
Copy Markdown
Contributor

PR types

Bug fixes

PR changes

Others

Description

Fix save_model usage.

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Oct 17, 2024

Thanks for your contribution!

Copy link
Copy Markdown
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 8da4248 into PaddlePaddle:release/3.0-beta2 Oct 17, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (036e1cd) to head (1cf3094).
Report is 49 commits behind head on release/3.0-beta2.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/3.0-beta2    #9287   +/-   ##
==================================================
  Coverage              52.94%   52.95%           
==================================================
  Files                    656      656           
  Lines                 106312   106315    +3     
==================================================
+ Hits                   56291    56297    +6     
+ Misses                 50021    50018    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants