Skip to content

[Tokenizer] Enable padding_side as call time kwargs#9258

Merged
ZHUI merged 4 commits into
PaddlePaddle:developfrom
DrownFish19:dev_20241012_padding-side
Oct 17, 2024
Merged

[Tokenizer] Enable padding_side as call time kwargs#9258
ZHUI merged 4 commits into
PaddlePaddle:developfrom
DrownFish19:dev_20241012_padding-side

Conversation

@DrownFish19
Copy link
Copy Markdown
Collaborator

PR types

Function optimization

PR changes

APIs

Description

Enable padding_side as call time kwargs.

This PR is based on #9161 and compatible with the function self._pad without the argument padding_size.

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Oct 14, 2024

Thanks for your contribution!

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.95%. Comparing base (e9532bc) to head (9c7336c).
Report is 272 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/tokenizer_utils_base.py 58.33% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9258      +/-   ##
===========================================
- Coverage    53.28%   52.95%   -0.34%     
===========================================
  Files          657      657              
  Lines       107485   106491     -994     
===========================================
- Hits         57275    56388     -887     
+ Misses       50210    50103     -107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI merged commit 5244e61 into PaddlePaddle:develop Oct 17, 2024
@DrownFish19 DrownFish19 deleted the dev_20241012_padding-side branch October 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants