Skip to content

[MLU] Fix Llama attrntion_mask in npu and mlu #9075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZHUI merged 2 commits into from
Sep 3, 2024
Merged

[MLU] Fix Llama attrntion_mask in npu and mlu #9075

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c41a152
fix
DrownFish19 Sep 3, 2024
519b4c7
update
DrownFish19 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paddlenlp/transformers/llama/modeling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1653,7 +1653,7 @@ def forward(
is_casual = True
else:
is_casual = is_casual_mask(attention_mask)
if get_env_device() != "npu" or get_env_device() != "mlu":
if get_env_device() != "npu" and get_env_device() != "mlu":
Copy link
Copy Markdown
Contributor

@ZHUI ZHUI Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if get_env_device() != "npu" and get_env_device() != "mlu":
if get_env_device() not in ["npu", "mlu"]:

Copy link
Copy Markdown
Contributor

@ZHUI ZHUI Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样会不会好一点

Copy link
Copy Markdown
Collaborator Author

@DrownFish19 DrownFish19 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯嗯，明确一些

if is_casual and alibi is None:
attention_mask = None
else:
Expand Down