Skip to content

Fix moe save load#9045

Merged
ZHUI merged 4 commits into
PaddlePaddle:developfrom
Meiyim:fix-moe-save-load
Aug 30, 2024
Merged

Fix moe save load#9045
ZHUI merged 4 commits into
PaddlePaddle:developfrom
Meiyim:fix-moe-save-load

Conversation

@Meiyim
Copy link
Copy Markdown
Contributor

@Meiyim Meiyim commented Aug 29, 2024

PR types

PR changes

Description

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Aug 29, 2024

Thanks for your contribution!

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.83%. Comparing base (a18e220) to head (53a1fad).
Report is 216 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 80.00% 2 Missing ⚠️
paddlenlp/trainer/utils/sharding_io.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9045      +/-   ##
===========================================
+ Coverage    53.58%   53.83%   +0.24%     
===========================================
  Files          652      652              
  Lines       105169   104520     -649     
===========================================
- Hits         56354    56265      -89     
+ Misses       48815    48255     -560     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 3ee8ab7 into PaddlePaddle:develop Aug 30, 2024
Mangodadada pushed a commit to Mangodadada/PaddleNLP that referenced this pull request Sep 10, 2024
* fix `upload signal` under pure dp and dp-moe (PaddlePaddle#8874)
---------

Co-authored-by: Ferrebo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants