Skip to content

【Fix】modify tensorboard requirements#8904

Merged
wawltor merged 5 commits into
PaddlePaddle:developfrom
greycooker:fix_tensorboard_requirements
Aug 12, 2024
Merged

【Fix】modify tensorboard requirements#8904
wawltor merged 5 commits into
PaddlePaddle:developfrom
greycooker:fix_tensorboard_requirements

Conversation

@greycooker
Copy link
Copy Markdown
Contributor

PR types

Fix

PR changes

Modify tensorboard requirements

Description

Summary writer can only be imported from tensorboardX.

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Aug 8, 2024

Thanks for your contribution!

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.29%. Comparing base (996198a) to head (c11d005).
Report is 241 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/integrations.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8904   +/-   ##
========================================
  Coverage    55.29%   55.29%           
========================================
  Files          631      631           
  Lines        98888    98884    -4     
========================================
  Hits         54681    54681           
+ Misses       44207    44203    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 6f3e736 into PaddlePaddle:develop Aug 12, 2024
@greycooker greycooker deleted the fix_tensorboard_requirements branch August 29, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants