Skip to content

Revert "Support Sharding Overlap (#8473)"#8491

Merged
wawltor merged 1 commit into
PaddlePaddle:developfrom
SylarTiaNII:revert_8473
May 24, 2024
Merged

Revert "Support Sharding Overlap (#8473)"#8491
wawltor merged 1 commit into
PaddlePaddle:developfrom
SylarTiaNII:revert_8473

Conversation

@SylarTiaNII
Copy link
Copy Markdown
Contributor

This reverts commit 7aaa788.

PR types

Bug fixes

PR changes

Others

Description

Revert PR#8473 to fix llama

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented May 24, 2024

Thanks for your contribution!

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.28%. Comparing base (7aaa788) to head (3a34b65).
Report is 219 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/llama/modeling.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8491      +/-   ##
===========================================
+ Coverage    54.25%   54.28%   +0.02%     
===========================================
  Files          617      617              
  Lines        96368    96356      -12     
===========================================
+ Hits         52288    52306      +18     
+ Misses       44080    44050      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 0cd8fe7 into PaddlePaddle:develop May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants