[LoRA] add quick_lora#8106
Merged
Merged
Conversation
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8106 +/- ##
===========================================
- Coverage 55.44% 55.41% -0.03%
===========================================
Files 596 597 +1
Lines 91464 91587 +123
===========================================
+ Hits 50713 50754 +41
- Misses 40751 40833 +82 ☔ View full report in Codecov by Sentry. |
gongel
previously approved these changes
Mar 14, 2024
…t be set to True to prevent any potential errors from occurring.
Member
|
冲突了 |
lugimzzz
reviewed
Mar 21, 2024
| input_grad = None | ||
|
|
||
| if not input.stop_gradient: | ||
| input_grad = paddle.addmm( |
Contributor
There was a problem hiding this comment.
求input_grad是不是可以考虑使用merged_weight，input_grad= paddle.matmul(grad_output, merged_weight, transpose_y=True)
Member
Author
There was a problem hiding this comment.
merged_weight这个东西没法从前向复用，复用会占用很大的显存。
然后如果合并计算的话，就无法复用 lora_B_input_grad = paddle.matmul(grad_output, lora_B, transpose_y=True)。需要重新计算一次
gongel
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
已知缺陷：