Skip to content

Specified pip version in dev image#9926

Merged
reyoung merged 1 commit into
PaddlePaddle:developfrom
Yancey0623:specifed_pip_version
Apr 16, 2018
Merged

Specified pip version in dev image#9926
reyoung merged 1 commit into
PaddlePaddle:developfrom
Yancey0623:specifed_pip_version

Conversation

@Yancey0623
Copy link
Copy Markdown
Contributor

@Yancey0623 Yancey0623 commented Apr 16, 2018

Fixed #9927

@Yancey0623 Yancey0623 requested a review from jacquesqiao April 16, 2018 02:08
Copy link
Copy Markdown
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread Dockerfile
# sphinx-rtd-theme] since -U option will cause sphinx being updated to newest
# version(1.7.1 for now), which causes building documentation failed.
RUN pip install --upgrade pip && \
RUN pip install --upgrade pip==9.0.3 && \
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we have a comment here explaining why we need the specific version 9.0.3 of pip? Thanks!

Copy link
Copy Markdown
Collaborator

@reyoung reyoung Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reyoung reyoung merged commit 672cc25 into PaddlePaddle:develop Apr 16, 2018
@Yancey0623 Yancey0623 deleted the specifed_pip_version branch April 16, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants