Move reduceSum to elementwise_op_function.h #9773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
force-pushed
the
feature/add_cuda_device_function
branch
from
a82eae0 to
67fb07d
Compare
chengduoZH
force-pushed
the
feature/add_cuda_device_function
branch
from
67fb07d to
d2901db
Compare
wangkuiyi
requested changes
Apr 9, 2018
Collaborator
There was a problem hiding this comment.
Please read #9770 (comment) for some key considerations when deriving a "principle". @chengduoZH
Contributor
Author
|
@wangkuiyi I see, thanks!!! |
chengduoZH
changed the title
chengduoZH
force-pushed
the
feature/add_cuda_device_function
branch
from
d911aea to
9efdf12
Compare
wangkuiyi
approved these changes
Apr 10, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #9770